git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: Possible BUG in 'git log --parents'
Date: Sun, 8 Jul 2007 12:33:08 +0200	[thread overview]
Message-ID: <e5bfff550707080333k6a225c6p74a7b0042e5739c8@mail.gmail.com> (raw)
In-Reply-To: <e5bfff550707080232q3e27581t45c0e4c5a1ea3b0f@mail.gmail.com>

On 7/8/07, Marco Costalba <mcostalba@gmail.com> wrote:
> On 7/8/07, Junio C Hamano <gitster@pobox.com> wrote:
> > Match "log --parent" output to "rev-list --parent" output.
> >
>
> Thanks. It works for me.
>

Sorry, I have to correct, it does *not* work for me.

Please apply your patch and give a look at:

git log --parents -n1 addafaf92e -r -m -- diff.h

What seems to happen is that duplicated entries are not removed by
diff machinery.

Although duplicated parents are correctly removed from parent list as
in git-rev-list, probably we should consider that git-log has also the
diff machinery attached.

Marco

P.S: Hope this little issue does not make you revert the patch ;-)

      reply	other threads:[~2007-07-08 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-07  9:49 Possible BUG in 'git log --parents' Marco Costalba
2007-07-07 10:09 ` Junio C Hamano
2007-07-07 10:14   ` Marco Costalba
2007-07-07 22:17     ` Marco Costalba
2007-07-08  7:59       ` Junio C Hamano
2007-07-08  9:32         ` Marco Costalba
2007-07-08 10:33           ` Marco Costalba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550707080333k6a225c6p74a7b0042e5739c8@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).