From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Fix "git log --parent -m" from emitting duplicated parent info
Date: Mon, 9 Jul 2007 07:46:10 +0200 [thread overview]
Message-ID: <e5bfff550707082246k39286517o58fe89d80e05e08@mail.gmail.com> (raw)
In-Reply-To: <7vps32xsof.fsf@assigned-by-dhcp.cox.net>
On 7/9/07, Junio C Hamano <gitster@pobox.com> wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> Second try, this time not doing the simplification when --full-history
> is given.
>
Probably I'm wrong but I would think the first original version with
post-filtering is more
correct.
Indeed we can use and _do_ use --full-history not only for printing
all revisions but to _walk_ the tree in a certain way, different from
default.
IMHO --parents + --full-history is absolutely legal because the first
flag indicate how to walk the tree and the second flag indicate what
to show to the user.
I agree the original patch is much uglier then your last version but I
would say is more correct.
Thanks
Marco
next prev parent reply other threads:[~2007-07-09 5:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 14:37 [PATCH] Fix "git log --parent -m" from emitting duplicated parent info Marco Costalba
2007-07-08 18:32 ` Junio C Hamano
2007-07-09 0:37 ` Junio C Hamano
2007-07-09 1:15 ` Johannes Schindelin
2007-07-09 1:28 ` Junio C Hamano
2007-07-09 1:20 ` Junio C Hamano
2007-07-09 1:22 ` Johannes Schindelin
2007-07-09 1:38 ` Junio C Hamano
2007-07-09 5:46 ` Marco Costalba [this message]
2007-07-09 6:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550707082246k39286517o58fe89d80e05e08@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).