From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Add --show-size to git log to print message size
Date: Mon, 16 Jul 2007 14:04:35 +0200 [thread overview]
Message-ID: <e5bfff550707160504p52770227l9af66aa750d9efd6@mail.gmail.com> (raw)
In-Reply-To: <7vodiehko7.fsf@assigned-by-dhcp.cox.net>
On 7/14/07, Junio C Hamano <gitster@pobox.com> wrote:
> "Marco Costalba" <mcostalba@gmail.com> writes:
>
>
> "size" is a bit vague here. What if we later want to extend
> things so that you can ask for the entire log entry size
> including the patch output part (I am not saying that would be
> an easy change --- I am more worried about the stability of the
> external interface). So is --show-"size". "message-size" would
> have been a bit easier to swallow, but I sense the problem runs
> deeper.
>
I'm rewriting the patch + documentation cleaned up and with a
different option name (--show-log).
Currently the patch just include the log message because the diff
content (-p option) is not buffered but is written with a combination
of printf, puts, fputs, fwrite and putchar directly to stdout.
My question is, there is a way to get the quantity of bytes written to
stdout before they are printed? I'm not an expert of C stdio library,
so perhaps this is nonsense, but I was thinking of reading the size of
stout buffer before to fflush() (I don't know if it is possible).
If it is not possible I have to give up in extending the scope of this
'show me the size' patch to diff content and I will stick to the
proper name --show-log.
Thanks
Marco
next prev parent reply other threads:[~2007-07-16 12:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 16:52 [PATCH] Add --show-size to git log to print message size Marco Costalba
2007-07-14 19:03 ` Junio C Hamano
2007-07-14 20:46 ` Marco Costalba
2007-07-15 9:35 ` Alex Riesen
2007-07-15 10:06 ` Marco Costalba
2007-07-15 10:48 ` Alex Riesen
2007-07-15 11:32 ` Marco Costalba
2007-07-15 12:29 ` Marco Costalba
2007-07-15 12:35 ` Sean
2007-07-15 14:58 ` Marco Costalba
2007-07-15 15:04 ` Sean
2007-07-15 15:58 ` Marco Costalba
2007-07-15 16:16 ` Sean
2007-07-15 16:27 ` Marco Costalba
2007-07-15 16:34 ` Sean
2007-07-15 16:54 ` Marco Costalba
2007-07-15 18:14 ` Linus Torvalds
2007-07-15 18:45 ` Marco Costalba
2007-07-16 12:04 ` Marco Costalba [this message]
2007-07-16 12:31 ` Alex Riesen
2007-07-16 17:50 ` Junio C Hamano
2007-07-16 17:55 ` Marco Costalba
2007-07-16 18:02 ` Marco Costalba
2007-07-16 22:37 ` Junio C Hamano
2007-07-16 17:50 ` Marco Costalba
2007-07-17 7:49 ` Andy Parkins
2007-07-17 16:36 ` Marco Costalba
2007-07-25 4:03 ` Junio C Hamano
2007-07-25 9:38 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550707160504p52770227l9af66aa750d9efd6@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).