From: "Marco Costalba" <mcostalba@gmail.com>
To: "Andy Parkins" <andyparkins@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <junkio@cox.net>
Subject: Re: [PATCH] Add --show-size to git log to print message size
Date: Tue, 17 Jul 2007 18:36:15 +0200 [thread overview]
Message-ID: <e5bfff550707170936kcd0c001nb4c4a90baacf4275@mail.gmail.com> (raw)
In-Reply-To: <200707170849.35842.andyparkins@gmail.com>
On 7/17/07, Andy Parkins <andyparkins@gmail.com> wrote:
>
> Does this really give a speedup?
>
> I'd be surprised, as long as the parse is being done during the output from
> git using the QProcess::readyRead() signal once and only once, then git is
> the bottle neck. Parsing the stream is almost trivial in comparison to the
> work that git is doing.
>
Well, it's not exactly from readyRead() but you are right, the bottle
neck it's git.
A bare:
time git log --parents --boundary --pretty=raw -z --log-size
--topo-order HEAD > /dev/null
gives on linux and git repositories
git 960ms
linux 6920ms
Instead qgit gives, with the same command:
WITHOUT --log-size patch
git 1170ms (+21%)
linux 7942ms (+15%)
WITH --log-size patch
git 1125ms (+17%)
linux 7820ms (+13%)
I don't know why overhead on Linux is less, probably on small repos
the GUI part of qgit that you can consider more or less a constant
time weights more regarding parsing.
Marco
next prev parent reply other threads:[~2007-07-17 16:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 16:52 [PATCH] Add --show-size to git log to print message size Marco Costalba
2007-07-14 19:03 ` Junio C Hamano
2007-07-14 20:46 ` Marco Costalba
2007-07-15 9:35 ` Alex Riesen
2007-07-15 10:06 ` Marco Costalba
2007-07-15 10:48 ` Alex Riesen
2007-07-15 11:32 ` Marco Costalba
2007-07-15 12:29 ` Marco Costalba
2007-07-15 12:35 ` Sean
2007-07-15 14:58 ` Marco Costalba
2007-07-15 15:04 ` Sean
2007-07-15 15:58 ` Marco Costalba
2007-07-15 16:16 ` Sean
2007-07-15 16:27 ` Marco Costalba
2007-07-15 16:34 ` Sean
2007-07-15 16:54 ` Marco Costalba
2007-07-15 18:14 ` Linus Torvalds
2007-07-15 18:45 ` Marco Costalba
2007-07-16 12:04 ` Marco Costalba
2007-07-16 12:31 ` Alex Riesen
2007-07-16 17:50 ` Junio C Hamano
2007-07-16 17:55 ` Marco Costalba
2007-07-16 18:02 ` Marco Costalba
2007-07-16 22:37 ` Junio C Hamano
2007-07-16 17:50 ` Marco Costalba
2007-07-17 7:49 ` Andy Parkins
2007-07-17 16:36 ` Marco Costalba [this message]
2007-07-25 4:03 ` Junio C Hamano
2007-07-25 9:38 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550707170936kcd0c001nb4c4a90baacf4275@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).