From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Alex Riesen" <raa.lkml@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Avoid to duplicate commit message when is not encoded
Date: Mon, 23 Jul 2007 00:04:33 +0200 [thread overview]
Message-ID: <e5bfff550707221504g395580e6jdde1f37a810302f0@mail.gmail.com> (raw)
In-Reply-To: <7v4pjwssp0.fsf@assigned-by-dhcp.cox.net>
On 7/22/07, Junio C Hamano <gitster@pobox.com> wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
>
> > Marco Costalba, Sun, Jul 22, 2007 10:23:05 +0200:
> >> + if (encoding) // we'll strip encoding header later
> >
> > You better avoid using C++ comments, not all C compilers support them.
>
> I've "fixed" them.
>
Sorry, I wrote them automatically without thinking it is better to
avoid them in C. BTW I would think it's more about coding style then
compiler support.
> >> + else
> >> + return NULL; // nothing to do
> >
> > And you better avoid such useless comments too
>
> I think this one is probably a good-to-have. It really needs a
> bit of thinking why there is nothing to do in this case. At
> least for me it did ;-)
>
Me too ;-)
prev parent reply other threads:[~2007-07-22 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 8:23 [PATCH] Avoid to duplicate commit message when is not encoded Marco Costalba
2007-07-22 8:40 ` Junio C Hamano
2007-07-22 8:52 ` Alex Riesen
2007-07-22 9:17 ` Junio C Hamano
2007-07-22 22:04 ` Marco Costalba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550707221504g395580e6jdde1f37a810302f0@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).