* [PATCH] Check for large pack offsets could be optimized away
@ 2007-08-16 7:58 Marco Costalba
0 siblings, 0 replies; only message in thread
From: Marco Costalba @ 2007-08-16 7:58 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List, Nicolas Pitre
Without this fix gcc 4.2.1 warns with:
warning: assuming signed overflow does not occur
when assuming that (X + c) < X is always false
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---
sha1_file.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index b219d4d..ba29000 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -524,7 +524,8 @@ static int check_packed_git_idx
if (idx_size != min_size) {
/* make sure we can deal with large pack offsets */
off_t x = 0x7fffffffUL, y = 0xffffffffUL;
- if (x > (x + 1) || y > (y + 1)) {
+ off_t x1 = x + 1, y1 = y + 1;
+ if (x > x1 || y > y1) {
munmap(idx_map, idx_size);
return error("pack too large for current definition of off_t in %s", path);
}
--
1.5.3.rc4.67.gf9286
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-16 7:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-16 7:58 [PATCH] Check for large pack offsets could be optimized away Marco Costalba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).