From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Fix an unitialized pointer in merge-recursive.c
Date: Thu, 16 Aug 2007 10:11:00 +0200 [thread overview]
Message-ID: <e5bfff550708160111n66b5ea94k26cf2fecc06fd84c@mail.gmail.com> (raw)
In-Reply-To: <7vsl6jkila.fsf@gitster.siamese.dyndns.org>
On 8/16/07, Junio C Hamano <gitster@pobox.com> wrote:
> "Marco Costalba" <mcostalba@gmail.com> writes:
>
> > Indeed &mrtree is passed to merge_trees() that not always
> > seems to set the value, so on some paths mrtree could
> > return uninitialized.
> >
> > Spotted by a gcc 4.2.1 warning
>
> Are you sure that gcc is correctly seeing the codeflow?
>
> In merge(), mrtree is used only under index_only, and
> merge_trees() always sets *result under index_only.
>
Ok ;-)
Now two options:
- discard the patch
- change the title in 'silence a gcc bougus warning'
next prev parent reply other threads:[~2007-08-16 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 8:00 [PATCH] Fix an unitialized pointer in merge-recursive.c Marco Costalba
2007-08-16 8:08 ` Junio C Hamano
2007-08-16 8:11 ` Marco Costalba [this message]
2007-08-16 8:23 ` Junio C Hamano
2007-08-16 8:30 ` Junio C Hamano
2007-08-16 9:07 ` David Kastrup
2007-08-16 13:16 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550708160111n66b5ea94k26cf2fecc06fd84c@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).