From: "Marco Costalba" <mcostalba@gmail.com>
To: "Pierre Habouzit" <madcoder@debian.org>,
"Marco Costalba" <mcostalba@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>, Git <git@vger.kernel.org>
Subject: Re: Big performance regression with --no-color option in git-log
Date: Sat, 29 Sep 2007 13:29:30 +0200 [thread overview]
Message-ID: <e5bfff550709290429n291968f2md8068a945ff7a79e@mail.gmail.com> (raw)
In-Reply-To: <20070929110914.GA32142@artemis.corp>
On 9/29/07, Pierre Habouzit <madcoder@debian.org> wrote:
> On Sat, Sep 29, 2007 at 11:01:30AM +0000, Pierre Habouzit wrote:
> > On Sat, Sep 29, 2007 at 10:02:23AM +0000, Marco Costalba wrote:
> > > On today git tree
>
> Okay for me it's not only from today, and the issue seems to be with
> the fact that we pass options or that we don't... git log --color also
> takes an awful lot of time here, whereas it's my default. Looks like
> diff_opt_parse is called too many times.
>
There was a patch some time ago to fix a similar issue with '-z'
option (66e41f7b9912), perhaps the fix could be the same also for
--no-color, --color, or other new options that force to actually
compute diffs when is not needed.
Marco
next prev parent reply other threads:[~2007-09-29 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 10:02 Big performance regression with --no-color option in git-log Marco Costalba
2007-09-29 11:01 ` Pierre Habouzit
2007-09-29 11:09 ` Pierre Habouzit
2007-09-29 11:29 ` Marco Costalba [this message]
2007-09-29 12:35 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Pierre Habouzit
2007-09-29 12:52 ` David Kastrup
2007-09-29 12:56 ` Pierre Habouzit
2007-09-29 13:06 ` Marco Costalba
2007-09-29 13:07 ` Marco Costalba
2007-09-29 16:50 ` Fix revision log diff setup, avoid unnecessary diff generation Linus Torvalds
2007-09-29 22:11 ` Junio C Hamano
2007-09-29 17:02 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550709290429n291968f2md8068a945ff7a79e@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).