git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line
@ 2007-10-27  9:10 Marco Costalba
  2007-10-27  9:36 ` Johannes Gilger
  0 siblings, 1 reply; 3+ messages in thread
From: Marco Costalba @ 2007-10-27  9:10 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git list, Yaacov Akiba Slama

Form git tree:

$ git log -n 1 8d863c98b2f9b0d37 | wc
      7      28     246

$ git log --no-color -n 1 8d863c98b2f9b0d37 | wc
      8      28     247

$ git --version
git version 1.5.3.2.124.g648db

What's worst is that when using --log-size option, the size is always
the same (198 in this case) breaking qgit parsing when --no-color
option is used.

BTW --no-color option is needed to correctly handle repositories where
"diff.color = true" in the configuration as pointed out (and patched)
by Yaacov Akiba Slama.

Thanks
Marco

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line
  2007-10-27  9:10 [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line Marco Costalba
@ 2007-10-27  9:36 ` Johannes Gilger
  2007-10-27 10:01   ` Marco Costalba
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Gilger @ 2007-10-27  9:36 UTC (permalink / raw)
  To: Marco Costalba, Git Mailing List

Marco Costalba wrote:
> Form git tree:
> 
> $ git log -n 1 8d863c98b2f9b0d37 | wc
>       7      28     246
> 
> $ git log --no-color -n 1 8d863c98b2f9b0d37 | wc
>       8      28     247
> 
> $ git --version
> git version 1.5.3.2.124.g648db

Hi,

using git version 1.5.3.4.383.gd90a7 i can't confirm this, the two
outputs are of the same length here.

Regards,
Johannes

-- 
Johannes Gilger <heipei@hackvalue.de>
http://hackvalue.de/heipei/
GPG-Key: 0x42F6DE81
GPG-Fingerprint: BB49 F967 775E BB52 3A81  882C 58EE B178 42F6 DE81

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line
  2007-10-27  9:36 ` Johannes Gilger
@ 2007-10-27 10:01   ` Marco Costalba
  0 siblings, 0 replies; 3+ messages in thread
From: Marco Costalba @ 2007-10-27 10:01 UTC (permalink / raw)
  To: Johannes Gilger; +Cc: Git Mailing List

On 10/27/07, Johannes Gilger <heipei@hackvalue.de> wrote:
> Marco Costalba wrote:
> > Form git tree:
> >
> > $ git log -n 1 8d863c98b2f9b0d37 | wc
> >       7      28     246
> >
> > $ git log --no-color -n 1 8d863c98b2f9b0d37 | wc
> >       8      28     247
> >
> > $ git --version
> > git version 1.5.3.2.124.g648db
>
> Hi,
>
> using git version 1.5.3.4.383.gd90a7 i can't confirm this, the two
> outputs are of the same length here.
>

Yes. With the latest git everything works as expected.

Sorry fo rthe noise!

Marco

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-10-27 10:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-27  9:10 [POSSIBLE BUG] 'git log' option --no-color adds bogus empty line Marco Costalba
2007-10-27  9:36 ` Johannes Gilger
2007-10-27 10:01   ` Marco Costalba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).