git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Brandon Casey" <casey@nrlssc.navy.mil>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] git-stash: add new 'drop' subcommand
Date: Sat, 5 Jan 2008 13:36:25 +0100	[thread overview]
Message-ID: <e5bfff550801050436k61760cv9cf5c04c537907d6@mail.gmail.com> (raw)
In-Reply-To: <477EDDD4.5060509@nrlssc.navy.mil>

On Jan 5, 2008 2:31 AM, Brandon Casey <casey@nrlssc.navy.mil> wrote:
>
>
> +drop_stash () {
> +       if ! have_stash
> +       then
> +               echo >&2 'No stash entries to drop'
> +               exit 0
> +       fi

Please, or

> +               echo >&2 'No stash entries to drop'
> +               exit 1

or

> +               echo 'No stash entries to drop'
> +               exit 0

I would prefer the latter.

Thanks
Marco

  parent reply	other threads:[~2008-01-05 12:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1199495198-26270-1-git-send-email-casey@nrlssc.navy.mil>
2008-01-05  1:31 ` [PATCH] git-stash: add new 'drop' subcommand Brandon Casey
2008-01-05  1:47   ` Junio C Hamano
2008-01-05  5:46     ` Brandon Casey
2008-01-05  3:51   ` Jeff King
2008-01-05  9:26     ` JM Ibanez
2008-01-05  9:35       ` [PATCH] git-stash clear: refuse to work with extra parameter for now Junio C Hamano
2008-01-05 10:00         ` Jeff King
2008-01-05 12:36   ` Marco Costalba [this message]
2008-01-07 17:12 [PATCH] git-stash: add new 'drop' subcommand Brandon Casey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550801050436k61760cv9cf5c04c537907d6@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).