gitk dev branch: F5 gives error after commit

gitk dev branch: F5 gives error after commit

[Johannes Sixt]

I use the dev branch of gitk (on Windows), commit 476ca63 (gitk: Index
[fnvr]highlights by id rather than row).

1. Start it with:

    gitk --all -300

2. Make a commit.
3. Hit F5. Here I see the error message:

   Error reading commits:
   fatal: bad revision '^-300'

At this time the label of the current branch is already gone from the
commit list. There are no other changes made in the display.

Hitting F5 again does nothing. I have to create a new view to get an
updated display.

Any help is appreciated. Thanks,
-- Hannes

Re: gitk dev branch: F5 gives error after commit

[Marco Costalba]

On Jan 7, 2008 5:52 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> I use the dev branch of gitk (on Windows), commit 476ca63 (gitk: Index
> [fnvr]highlights by id rather than row).
>
> 1. Start it with:
>
>     gitk --all -300
>
> 2. Make a commit.
> 3. Hit F5. Here I see the error message:
>
>    Error reading commits:
>    fatal: bad revision '^-300'
>

Windows command line does not handles the  ^ symbol.

Try open a console with cmd.exe and type

git log HEAD^


Marco

Re: gitk dev branch: F5 gives error after commit

[Paul Mackerras]

Johannes Sixt writes:

> I use the dev branch of gitk (on Windows), commit 476ca63 (gitk: Index
> [fnvr]highlights by id rather than row).
> 
> 1. Start it with:
> 
>     gitk --all -300
> 
> 2. Make a commit.
> 3. Hit F5. Here I see the error message:
> 
>    Error reading commits:
>    fatal: bad revision '^-300'

This happens because I naively thought 'git rev-parse --revs-only'
would only give me SHA1 IDs.  But in any case gitk (on the dev branch)
doesn't really do anything much to handle commit selection flags that
can't be turned into SHA1 IDs (possibly negated).

Thanks for testing.  I'll fix it.

Paul.