From: "Marco Costalba" <mcostalba@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>, "Nicolas Pitre" <nico@cam.org>
Subject: Re: [PATCH 6/6] Use new compress helpers in builtin-pack-objects.c
Date: Fri, 11 Jan 2008 07:10:49 +0100 [thread overview]
Message-ID: <e5bfff550801102210g181a091s28725e24922b9b12@mail.gmail.com> (raw)
In-Reply-To: <e5bfff550801101334p5df5adaerf0eeae02ddf28334@mail.gmail.com>
On Jan 10, 2008 10:34 PM, Marco Costalba <mcostalba@gmail.com> wrote:
>
> - while (deflate(&stream, Z_FINISH) == Z_OK)
> - /* nothing */;
> - deflateEnd(&stream);
> - datalen = stream.total_out;
> - deflateEnd(&stream);
One thing I would like someone to clarify is why deflateEnd(&stream)
is called two times ?
With my patch is called only once as I have seen in all the others places.
Thanks
Marco
next prev parent reply other threads:[~2008-01-11 6:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 21:34 [PATCH 6/6] Use new compress helpers in builtin-pack-objects.c Marco Costalba
2008-01-10 22:26 ` Nicolas Pitre
2008-01-11 6:10 ` Marco Costalba [this message]
2008-01-11 7:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550801102210g181a091s28725e24922b9b12@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).