From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: [PATCH 4/5] Use new compress helpers in http-push.c
Date: Fri, 11 Jan 2008 08:39:45 +0100 [thread overview]
Message-ID: <e5bfff550801102339o757eea62h40b5e00cd904f7e1@mail.gmail.com> (raw)
A multistep compress is required here, so
we need the full arsenal of compress helpers.
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---
http-push.c | 22 ++++++++--------------
1 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/http-push.c b/http-push.c
index 55d0c94..b7fe57f 100644
--- a/http-push.c
+++ b/http-push.c
@@ -1,5 +1,6 @@
#include "cache.h"
#include "commit.h"
+#include "compress.h"
#include "pack.h"
#include "tag.h"
#include "blob.h"
@@ -491,31 +492,24 @@ static void start_put(struct transfer_request
hdrlen = sprintf(hdr, "%s %lu", typename(type), len) + 1;
/* Set it up */
- memset(&stream, 0, sizeof(stream));
- deflateInit(&stream, zlib_compression_level);
- size = deflateBound(&stream, len + hdrlen);
+ size = compress_alloc(&stream, zlib_compression_level, len + hdrlen);
strbuf_init(&request->buffer.buf, size);
request->buffer.posn = 0;
/* Compress it */
- stream.next_out = (unsigned char *)request->buffer.buf.buf;
- stream.avail_out = size;
+ compress_start(&stream, (void *)hdr, hdrlen,
+ (unsigned char *)request->buffer.buf.buf, size);
/* First header.. */
- stream.next_in = (void *)hdr;
- stream.avail_in = hdrlen;
- while (deflate(&stream, 0) == Z_OK)
- /* nothing */;
+ compress_next(&stream, Z_NO_FLUSH);
/* Then the data itself.. */
stream.next_in = unpacked;
stream.avail_in = len;
- while (deflate(&stream, Z_FINISH) == Z_OK)
- /* nothing */;
- deflateEnd(&stream);
- free(unpacked);
+ compress_next(&stream, Z_FINISH);
- request->buffer.buf.len = stream.total_out;
+ request->buffer.buf.len = compress_free(&stream);
+ free(unpacked);
request->url = xmalloc(strlen(remote->url) +
strlen(request->lock->token) + 51);
--
1.5.4.rc2.89.g1b3f-dirty
next reply other threads:[~2008-01-11 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 7:39 Marco Costalba [this message]
2008-01-11 15:39 ` [PATCH 4/5] Use new compress helpers in http-push.c Kristian Høgsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550801102339o757eea62h40b5e00cd904f7e1@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).