git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Print Precedes/Follows in git log
@ 2008-01-14 23:34 Jan Engelhardt
  2008-01-15  6:38 ` Marco Costalba
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2008-01-14 23:34 UTC (permalink / raw)
  To: git

Hi,


gitk has a nice feature in that, when a commit is selected, it prints in 
the log window something like:

(id 1beeffe43311f64df8dd0ab08ff6b1858c58363f)

Author: Tony Jones <tonyj@suse.de>  2007-08-20 22:46:20
Committer: Mark M. Hoffman <mhoffman@lightlink.com>  2007-10-10 04:56:30
Parent: 8afb10490b18e916e33707baa7d1cfc615d545ea (hwmon: (f71882fg) trivial whitespace cleanup)
Branches: ...
Follows: v2.6.23
Precedes: v2.6.24-rc1

And it would be really nice if `git log` would also show the 
Precedes/Follows lines so one can identify much more easily in
big logs like those of the Linux kernel what the next release to
have a given patch is.


thanks,
Jan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Print Precedes/Follows in git log
  2008-01-14 23:34 Print Precedes/Follows in git log Jan Engelhardt
@ 2008-01-15  6:38 ` Marco Costalba
  0 siblings, 0 replies; 2+ messages in thread
From: Marco Costalba @ 2008-01-15  6:38 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: git

On Jan 15, 2008 12:34 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
>
> And it would be really nice if `git log` would also show the
> Precedes/Follows lines so one can identify much more easily in
> big logs like those of the Linux kernel what the next release to
> have a given patch is.
>
>

You need two complete revisions walk for this, one from the newest to
oldset to compute the 'precedes' and one from the oldest to newest to
compute the 'follows', so I would say it's more suitable used together
with --topo-order option of git log that already does a walk, at least
the slowdown is hidden in this case.

Anyhow being able to compute precedes/following info in timely fashion
and with low memory consumption is quite not trivial code, I have
implemented for qgit long time ago and I remember gave a kook at the
gitk code for reference also if at the end my implementation it's a
bit different (less memory used but slightly more complicated).

Just to give an idea of timing, on my new and awesome ;-) laptop
loading full Linux tree it takes 3316ms, then calculating
precedes/follows info (indexing the tree) it takes 233ms.

Perhaps the slowest part is to load refs info, you need this to know
what sha a tag/branch has and is a prerequisite to indexing, also if
refs are compacted it takes almost 1 second on my PC because there is
heavy disk activity in any case.

Marco

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-15  6:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-14 23:34 Print Precedes/Follows in git log Jan Engelhardt
2008-01-15  6:38 ` Marco Costalba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).