git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: fast-import.c: zlib_compression_level vs pack_compression_level
Date: Fri, 18 Jan 2008 14:04:30 +0100	[thread overview]
Message-ID: <e5bfff550801180504v17df7976x59d12f210efe583e@mail.gmail.com> (raw)

Just a small thing I would like to bring to your attention before 1.5.4 is out

During my work on compression/decompression cleanup I have found that
in fast-import.c the zlib_compression_level is used, while in
builtin-pack-objects is used pack_compression_level instead.

This 2 flags corresponds, more or less directly, (some cleanup is
needed also in that area, but this is another story) to:

core.loosecompression

and

pack.compression

config settings.

My question is, does fast-import should use pack.compression instead
of core.loosecompression?

Thanks
Marco

             reply	other threads:[~2008-01-18 13:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 13:04 Marco Costalba [this message]
2008-01-18 15:44 ` fast-import.c: zlib_compression_level vs pack_compression_level Nicolas Pitre
2008-01-19  8:47   ` Marco Costalba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550801180504v17df7976x59d12f210efe583e@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).