* fast-import.c: zlib_compression_level vs pack_compression_level
@ 2008-01-18 13:04 Marco Costalba
2008-01-18 15:44 ` Nicolas Pitre
0 siblings, 1 reply; 3+ messages in thread
From: Marco Costalba @ 2008-01-18 13:04 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List
Just a small thing I would like to bring to your attention before 1.5.4 is out
During my work on compression/decompression cleanup I have found that
in fast-import.c the zlib_compression_level is used, while in
builtin-pack-objects is used pack_compression_level instead.
This 2 flags corresponds, more or less directly, (some cleanup is
needed also in that area, but this is another story) to:
core.loosecompression
and
pack.compression
config settings.
My question is, does fast-import should use pack.compression instead
of core.loosecompression?
Thanks
Marco
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fast-import.c: zlib_compression_level vs pack_compression_level
2008-01-18 13:04 fast-import.c: zlib_compression_level vs pack_compression_level Marco Costalba
@ 2008-01-18 15:44 ` Nicolas Pitre
2008-01-19 8:47 ` Marco Costalba
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Pitre @ 2008-01-18 15:44 UTC (permalink / raw)
To: Marco Costalba; +Cc: Junio C Hamano, Git Mailing List
On Fri, 18 Jan 2008, Marco Costalba wrote:
> My question is, does fast-import should use pack.compression instead
> of core.loosecompression?
Yes it should.
Nicolas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fast-import.c: zlib_compression_level vs pack_compression_level
2008-01-18 15:44 ` Nicolas Pitre
@ 2008-01-19 8:47 ` Marco Costalba
0 siblings, 0 replies; 3+ messages in thread
From: Marco Costalba @ 2008-01-19 8:47 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: Junio C Hamano, Git Mailing List
On Jan 18, 2008 4:44 PM, Nicolas Pitre <nico@cam.org> wrote:
> On Fri, 18 Jan 2008, Marco Costalba wrote:
>
> > My question is, does fast-import should use pack.compression instead
> > of core.loosecompression?
>
> Yes it should.
>
I have a patch on top of my comrpession cleanup series, if people
agree I would leave this as is now. It's really not a biggie and 1.5.4
_seems_ very near.
Marco
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-19 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-18 13:04 fast-import.c: zlib_compression_level vs pack_compression_level Marco Costalba
2008-01-18 15:44 ` Nicolas Pitre
2008-01-19 8:47 ` Marco Costalba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).