git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH TAKE 2] Avoid a useless prefix lookup in strbuf_expand()
Date: Sun, 10 Feb 2008 07:59:45 +0100	[thread overview]
Message-ID: <e5bfff550802092259u4139312cufc4756e9d81f4154@mail.gmail.com> (raw)
In-Reply-To: <7vr6fl5yhz.fsf@gitster.siamese.dyndns.org>

On Feb 10, 2008 3:36 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Marco Costalba <mcostalba@gmail.com> writes:
>
> > Currently the --prett=format prefix is looked up in a
>
> s/prett/&y/;
>
> > New patch with Junio suggestions included.
>
> Hmph, this is a blast from the past.
>
> I do recall pointing out that a rather common "format:%an <%ae>"
> ends up parsing the same line twice, and mentioned we may want
> to memoise the first call's result in the format_commit_context
> structure, but what else did I suggest???
>

Please read thread: "[PATCH RESEND] Avoid a useless prefix lookup in
strbuf_expand()"

you will find your suggestions and following answers.

> Anyway, I'll take a look later.  Thanks.
>

Thanks
Marco

  reply	other threads:[~2008-02-10  7:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 14:40 [PATCH TAKE 2] Avoid a useless prefix lookup in strbuf_expand() Marco Costalba
2008-02-10  2:36 ` Junio C Hamano
2008-02-10  6:59   ` Marco Costalba [this message]
2008-02-10 10:52     ` Junio C Hamano
2008-02-10  2:52 ` Johannes Schindelin
2008-02-10  7:00   ` Marco Costalba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550802092259u4139312cufc4756e9d81f4154@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).