* Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" @ 2008-08-19 17:38 Marco Costalba 2008-08-19 17:51 ` Marcus Griep 0 siblings, 1 reply; 4+ messages in thread From: Marco Costalba @ 2008-08-19 17:38 UTC (permalink / raw) To: Junio C Hamano; +Cc: git mailing list Looking the diff at http://git.kernel.org/?p=git/git.git;a=commitdiff;h=289796dd29dd656734cfd59b657deb943a71cf6a the part of the patch applied to /t/t5100/sample.mbox file seems very strange, is it correct ? Marco ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" 2008-08-19 17:38 Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" Marco Costalba @ 2008-08-19 17:51 ` Marcus Griep 2008-08-19 17:57 ` Marcus Griep 0 siblings, 1 reply; 4+ messages in thread From: Marcus Griep @ 2008-08-19 17:51 UTC (permalink / raw) To: Marco Costalba; +Cc: Junio C Hamano, git mailing list [-- Attachment #1: Type: text/plain, Size: 573 bytes --] Marco Costalba wrote: > Looking the diff at > > http://git.kernel.org/?p=git/git.git;a=commitdiff;h=289796dd29dd656734cfd59b657deb943a71cf6a > > the part of the patch applied to /t/t5100/sample.mbox file seems very > strange, is it correct ? It looks like an empty line added to the end of the file. Unsanitary, but ok since it comes after the last MIME multipart boundary. Junio could probably just ax the change to sample.mbox from the patch before applying it. -- Marcus Griep GPG Key ID: 0x5E968152 —— http://www.boohaunt.net את.ψο´ [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 793 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" 2008-08-19 17:51 ` Marcus Griep @ 2008-08-19 17:57 ` Marcus Griep 2008-08-20 13:10 ` Don Zickus 0 siblings, 1 reply; 4+ messages in thread From: Marcus Griep @ 2008-08-19 17:57 UTC (permalink / raw) To: Marco Costalba; +Cc: Junio C Hamano, git mailing list [-- Attachment #1: Type: text/plain, Size: 624 bytes --] Marcus Griep wrote: > It looks like an empty line added to the end of the file. > Unsanitary, but ok since it comes after the last MIME > multipart boundary. Junio could probably just ax the change > to sample.mbox from the patch before applying it. Or I could have misunderstood the intent of the change, and it is necessary to fully test the change, since it appears to operate line-by-line, an empty line at the end would be necessary to trigger the code path that stops mailinfo from looking for another boundary. -- Marcus Griep GPG Key ID: 0x5E968152 —— http://www.boohaunt.net את.ψο´ [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 793 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" 2008-08-19 17:57 ` Marcus Griep @ 2008-08-20 13:10 ` Don Zickus 0 siblings, 0 replies; 4+ messages in thread From: Don Zickus @ 2008-08-20 13:10 UTC (permalink / raw) To: Marcus Griep; +Cc: Marco Costalba, Junio C Hamano, git mailing list On Tue, Aug 19, 2008 at 1:57 PM, Marcus Griep <neoeinstein@gmail.com> wrote: > Marcus Griep wrote: >> It looks like an empty line added to the end of the file. >> Unsanitary, but ok since it comes after the last MIME >> multipart boundary. Junio could probably just ax the change >> to sample.mbox from the patch before applying it. No the change was intentional. In fact, because that extra line was not there, a bug was hidden. Adding the extra line exposed the bug and hopefully will catch any more bugs in the future with regards to the boundary code. > > Or I could have misunderstood the intent of the change, and it > is necessary to fully test the change, since it appears to > operate line-by-line, an empty line at the end would be necessary > to trigger the code path that stops mailinfo from looking for > another boundary. Yes, exactly. Cheers, Don ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-20 13:11 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-08-19 17:38 Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" Marco Costalba 2008-08-19 17:51 ` Marcus Griep 2008-08-19 17:57 ` Marcus Griep 2008-08-20 13:10 ` Don Zickus
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).