From: Marco Costalba <mcostalba@gmail.com>
To: markus.heidelberg@web.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH QGit RFC] Fix "Save patch..." on a commit range
Date: Mon, 15 Jun 2009 22:25:02 +0100 [thread overview]
Message-ID: <e5bfff550906151425p2dacdcdasbae09af4ce34813d@mail.gmail.com> (raw)
In-Reply-To: <200906152313.20002.markus.heidelberg@web.de>
On Mon, Jun 15, 2009 at 22:13, Markus
Heidelberg<markus.heidelberg@web.de> wrote:
> Markus Heidelberg, 13.06.2009:
>>
>> I tested with the latest qgit.git and with QGit 2.2 from my
>> distribution. All on Gentoo Linux.
>>
>> I just built QGit 2.3, this has the same problems.
>>
>> [...]
>>
>> I will try to reproduce on Windows, probably after this weekend.
>
> Some news, tested with the 4 commits in git.git around v1.6.3 as before:
>
> It works correctly with QGit-2.3 installed from the Windows installer
> (http://sourceforge.net/projects/qgit).
>
> It works reversed when using a self-compiled qgit.
> gcc: mingw-gcc 3.4.5
> Qt: 4.4.1
>
> Reversed means, git-format-patch is invoked like this:
> git format-patch v1.6.3..v1.6.3~3^
> and doesn't produce patch files, instead of:
> git format-patch v1.6.3~3^..v1.6.3
>
> The strange behaviour of getting only 2 patches on Linux, I couldn't
> reproduce on Windows.
>
> You use MSVC, don't you? Can you please try with mingw? It would be
> really helpful, if you could reproduce it.
>
> Markus
>
>
This is really strange !
Yes I use MSVC, I cannot try mingw-gcc because I should recompile all
Qt with gcc.
But I can test on Linux tomorrow evening and see what's happens
there...but there is _nothing_ in the code that is platform dependent,
see Git::formatPatch() in git.cpp
next prev parent reply other threads:[~2009-06-15 21:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 23:29 [PATCH QGit RFC] Fix "Save patch..." on a commit range Markus Heidelberg
2009-06-13 7:13 ` Marco Costalba
2009-06-13 10:11 ` Markus Heidelberg
2009-06-13 11:02 ` Markus Heidelberg
2009-06-13 11:12 ` Marco Costalba
2009-06-13 11:33 ` Markus Heidelberg
2009-06-13 12:23 ` Marco Costalba
2009-06-15 21:13 ` Markus Heidelberg
2009-06-15 21:25 ` Marco Costalba [this message]
2009-06-15 21:45 ` Marco Costalba
2009-06-15 22:07 ` Marco Costalba
2009-06-15 23:53 ` Markus Heidelberg
2009-06-16 6:10 ` Marco Costalba
2009-06-16 18:48 ` Markus Heidelberg
2009-06-15 23:44 ` Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550906151425p2dacdcdasbae09af4ce34813d@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).