git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Costalba <mcostalba@gmail.com>
To: Markus Heidelberg <markus.heidelberg@web.de>,
	Git Mailing List <git@vger.kernel.org>
Subject: [PATCH QGit] Fix "Save patch..." when selected directory name has  spaces
Date: Wed, 17 Jun 2009 12:00:11 +0200	[thread overview]
Message-ID: <e5bfff550906170300r34000049o50ab107071cb7b2f@mail.gmail.com> (raw)

Bug spotted by Markus Heidelberg.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
---
 src/git.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/git.cpp b/src/git.cpp
index 357383d..bf1a9d5 100644
--- a/src/git.cpp
+++ b/src/git.cpp
@@ -1569,7 +1569,7 @@ bool Git::formatPatch(SCList shaList, SCRef
dirPath, SCRef remoteDir) {
 	if (remote)
 		runCmd.append(" --keep-subject");

-	runCmd.append(" -o " + dirPath);
+	runCmd.append(" -o " + quote(dirPath));
 	if (!FPOpt.isEmpty())
 		runCmd.append(" " + FPOpt.trimmed());

-- 
1.6.1.9.g97c34

                 reply	other threads:[~2009-06-17 10:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550906170300r34000049o50ab107071cb7b2f@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=markus.heidelberg@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).