From: Marco Costalba <mcostalba@gmail.com>
To: Abdelrazak Younes <younes@lyx.org>
Cc: git@vger.kernel.org
Subject: Re: [QGIT PATCH/RFC]
Date: Thu, 5 Nov 2009 10:41:27 +0100 [thread overview]
Message-ID: <e5bfff550911050141t751d45a0r4e340fa0d10af366@mail.gmail.com> (raw)
In-Reply-To: <4AF19630.2070402@lyx.org>
Hi Abdel,
On Wed, Nov 4, 2009 at 15:56, Abdelrazak Younes <younes@lyx.org> wrote:
> Hello Marco,
>
> While recompiling latest qgit4, I stumbled accross this. I am not quite sure
> you used a QLatin1String instead of a QByteArray but the attached seems to
> work fine...
>
Unfortunatly I cannot say the same here ;-)
>-class ShaString;
>+typedef QByteArray ShaString;
...... cut ......
>
> uint qHash(const ShaString& s) { // fast path, called 6-7 times per
> revision
>
Function:
uint qHash(const QByteArray&);
is already defined in the Qt Core libraries, so I have a link error
with your patch.
BTW I don't think I have understood the reason of your patch. Do you
have a compile error or something ?
Thanks
Marco
next prev parent reply other threads:[~2009-11-05 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 14:56 [QGIT PATCH/RFC] Abdelrazak Younes
2009-11-05 9:41 ` Marco Costalba [this message]
2009-11-05 9:50 ` Abdelrazak Younes
2009-11-05 10:13 ` Abdelrazak Younes
2009-11-05 10:19 ` Abdelrazak Younes
2009-11-05 10:37 ` Abdelrazak Younes
2009-11-05 20:25 ` Marco Costalba
2009-11-05 20:27 ` Marco Costalba
2009-11-06 8:15 ` Abdelrazak Younes
2009-11-06 8:16 ` Abdelrazak Younes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550911050141t751d45a0r4e340fa0d10af366@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=younes@lyx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).