From: "Marvin Häuser" <mhaeuser@posteo.de>
To: Carlo Arenas <carenas@gmail.com>
Cc: git@vger.kernel.org, tr@thomasrast.ch
Subject: Re: [RFC PATCH] send-email: allow fixing the cover letter subject
Date: Wed, 25 Aug 2021 06:31:18 +0000 [thread overview]
Message-ID: <e781b15c-8c59-9827-b052-ebe971b01cad@posteo.de> (raw)
In-Reply-To: <CAPUEspgmKPhbPGs+ujy7KVJCyNxS95ph2Dwvd7A7cH2J0em20g@mail.gmail.com>
On 24/08/2021 18:11, Carlo Arenas wrote:
> On Tue, Aug 24, 2021 at 8:19 AM Marvin Häuser <mhaeuser@posteo.de> wrote:
>> On 24/08/2021 13:41, Carlo Marcelo Arenas Belón wrote:
>>> @@ -1719,7 +1719,6 @@ sub process_file {
>>> @xh = ();
>>> my $input_format = undef;
>>> my @header = ();
>>> - $subject = $initial_subject;
>> This change from my patch is still controversial, and I'd rather not
>> submit the addition if it's immediately removed again.
>> Why are you dropping it here anyway, does it break any related
>> functionality?
> I was expecting it to break --compose, but it didn't because in there
> we were using $initial_subject directly instead.
Right, ok.
> AFAIK; I couldn't see a difference eitherway, but as Peff pointed out
> it doesn't make sense leaving it only as a global so just found
> instead a more useful place for it to be reset in the loop, which also
> "fix" another issue of mine.
Well, this only "sometimes" resets it (from a control flow perspective),
which is exactly what I tried to avoid globally.
Can we somehow agree on something? Because I'd like to submit my patch asap.
Best regards,
Marvin
next prev parent reply other threads:[~2021-08-25 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 11:41 [RFC PATCH] send-email: allow fixing the cover letter subject Carlo Marcelo Arenas Belón
2021-08-24 15:19 ` Marvin Häuser
2021-08-24 16:11 ` Carlo Arenas
2021-08-25 6:31 ` Marvin Häuser [this message]
2021-08-26 10:58 ` Carlo Arenas
2021-08-26 19:31 ` Marvin Häuser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e781b15c-8c59-9827-b052-ebe971b01cad@posteo.de \
--to=mhaeuser@posteo.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).