From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] send-email: Use setlocale in addition to $ENV{LC_ALL} to set locale
Date: Wed, 21 Jun 2006 13:18:40 +0200 [thread overview]
Message-ID: <e7b9u7$974$1@sea.gmane.org> (raw)
In-Reply-To: 20060621104941.GB15748@localdomain
Eric Wong wrote:
> Jakub Narebski <jnareb@gmail.com> wrote:
>>
>>> $ENV{LC_ALL} = 'C'; does not change locale used by strftime.
>>> Use setlocale( &LC_ALL, 'C' ); instead.
> I'm responsible for the $ENV{LC_ALL} = 'C' setting but I never actually
> tested how things would work with a non-English locale (not being
> well-versed in these things myself, either).
It looks like I have broken locale badly somewhat, as I yesterday
sent patches successfully without the patch. I suspect that sendmail
removes incorrect Date: header and adds it's own... unless Date:
header contains characters outside US-ASCII.
It means that sendmail can deal with
Date: wto, 20 cze 2006 13:14:11 +0200
instead of correct
Date: Tue, 20 Jun 2006 13:14:11 +0200
but cannot deal with (iso-8859-2 encoded I think)
Date: ¶ro, 21 cze 2006 09:48:02 +0200
from git-send-email.perl without patch, instead of correct
Date: Wed, 21 Jun 2006 11:25:52 +0200
with the patch.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-06-21 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11508760843417-git-send-email-jnareb@gmail.com>
[not found] ` <11508760842024-git-send-email-jnareb@gmail.com>
2006-06-21 8:05 ` [PATCH 1/3] gitweb: whitespace cleanup Jakub Narebski
2006-06-21 9:04 ` [PATCH 0/3] Minor gitweb modifications and cleanups Junio C Hamano
2006-06-21 9:12 ` [PATCH] send-email: Use setlocale in addition to $ENV{LC_ALL} to set locale Jakub Narebski
2006-06-21 10:33 ` Jakub Narebski
2006-06-21 10:49 ` Eric Wong
2006-06-21 11:18 ` Jakub Narebski [this message]
2006-07-03 2:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e7b9u7$974$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).