Re: Git on MSys (or how to make it easy for Windows users to compile git)

["Torgil Svensson" <torgil.svensson@gmail.com>]

On 8/4/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>

Hi

Thank you for your reply.

> > 1. Unpacking in a folder that have space in it's path gave various
> > errors of this type (here, msysGit is unpacked on the desktop
> > C:\Documents and settings\.... ) : make[1]: C:/Documents: Command not
> > found
>
> Good point.  Did you fix it?  If so, where is the patch?  Or even better,
> what is your account on repo.or.cz so I can add it, and you can commit
> your fix yourself?

I didn't. I bypassed it (unpacked to C:\). I found the bug however
(missed quoting):

$ diff -urN msysGit msysGit-fixed
diff -urN msysGit/git/git-gui/Makefile msysGit-fixed/git/git-gui/Makefile
--- msysGit/git/git-gui/Makefile        Fri Aug  3 15:00:16 2007
+++ msysGit-fixed/git/git-gui/Makefile  Mon Aug  6 01:22:53 2007
@@ -4,7 +4,7 @@
 #

 GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE
-       @$(SHELL_PATH) ./GIT-VERSION-GEN
+       @"$(SHELL_PATH)" ./GIT-VERSION-GEN
 -include GIT-VERSION-FILE

 uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
diff: msysGit/git/gitweb/test/M?¤rchen: No such file or directory
diff: msysGit-fixed/git/gitweb/test/M?¤rchen: No such file or directory


I'll make an account and send you the details when I get an public
SSH-key, haven't done that in windows before. Can I share private key
on both windows and Linux box?


> > 2. rxvt-terminal had some freezes
> I did not experience those.  Could you research further?

Some observations:
"git log" on mingw archive trigger this every time for me (hangs on
different places each time).

"cmd" terminal (msys.bat) seems to pipe "git log" to less while rxvt
terminal outputs lots of text very fast (msys-rxvt.bat) and freezes.
Output:ing lots of text itself doesn't seem to be an issue ("make -d"
doesn't freeze and outputs _lots_ of text)


> > 3. "gitk --all" said "Error reading commits: fatal: write failure on
> > stdout: Invalid argument"
> I did not even bother testing gitk...  Any idea what is going wrong?

The fconfigure -blocking command seems to be not supported under
mingw. This patch makes the error go away. Another issue that is
probably related to this is that gitk doesn't list all commits. I
don't know how to solve this properly.

diff --git a/gitk b/gitk
index 43d88ca..69e5149 100755
--- a/gitk
+++ b/gitk
@@ -147,7 +147,7 @@ proc getcommitlines {fd view}  {
        unset commfd($view)
        notbusy $view
        # set it blocking so we wait for the process to terminate
-       fconfigure $fd -blocking 1
+       #fconfigure $fd -blocking 1
        if {[catch {close $fd} err]} {
            set fv {}
            if {$view != $curview} {


$ grep '\-blocking' gitk | wc -l
     10

(all sets blocking to 0 except for the one in getcommitlines above)



> > 4. Mouse-wheel didn't work to scroll views in gitk
>
> Again, no idea why.  Could you please investigate?

Tough one since I didn't take the tcl tk debugging class. Doesn't work
for me in cygwin either. I don't know if it's implemented at all. Does
it work for anyone else?


//Torgil