* [PATCH] t2018: remove unwanted empty line
@ 2017-09-17 10:19 Kaartic Sivaraam
2017-09-17 19:22 ` Kevin Daudt
0 siblings, 1 reply; 3+ messages in thread
From: Kaartic Sivaraam @ 2017-09-17 10:19 UTC (permalink / raw)
To: git
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
t/t2018-checkout-branch.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/t/t2018-checkout-branch.sh b/t/t2018-checkout-branch.sh
index 2131fb2a5682c..e0a52334a22dd 100755
--- a/t/t2018-checkout-branch.sh
+++ b/t/t2018-checkout-branch.sh
@@ -192,7 +192,6 @@ test_expect_success 'checkout -b <describe>' '
test_expect_success 'checkout -B to the current branch works' '
git checkout branch1 &&
git checkout -B branch1-scratch &&
-
setup_dirty_mergeable &&
git checkout -B branch1-scratch initial &&
test_dirty_mergeable
--
https://github.com/git/git/pull/403
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] t2018: remove unwanted empty line
2017-09-17 10:19 [PATCH] t2018: remove unwanted empty line Kaartic Sivaraam
@ 2017-09-17 19:22 ` Kevin Daudt
2017-09-18 13:37 ` Kaartic Sivaraam
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Daudt @ 2017-09-17 19:22 UTC (permalink / raw)
To: Kaartic Sivaraam; +Cc: git
On Sun, Sep 17, 2017 at 10:19:28AM +0000, Kaartic Sivaraam wrote:
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
> t/t2018-checkout-branch.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/t/t2018-checkout-branch.sh b/t/t2018-checkout-branch.sh
> index 2131fb2a5682c..e0a52334a22dd 100755
> --- a/t/t2018-checkout-branch.sh
> +++ b/t/t2018-checkout-branch.sh
> @@ -192,7 +192,6 @@ test_expect_success 'checkout -b <describe>' '
> test_expect_success 'checkout -B to the current branch works' '
> git checkout branch1 &&
> git checkout -B branch1-scratch &&
> -
> setup_dirty_mergeable &&
> git checkout -B branch1-scratch initial &&
> test_dirty_mergeable
>
> --
> https://github.com/git/git/pull/403
Why is this empty line unwanted? This kind of whitespace can help
separate logical sections, just like paragraphs would.
Kevin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] t2018: remove unwanted empty line
2017-09-17 19:22 ` Kevin Daudt
@ 2017-09-18 13:37 ` Kaartic Sivaraam
0 siblings, 0 replies; 3+ messages in thread
From: Kaartic Sivaraam @ 2017-09-18 13:37 UTC (permalink / raw)
To: Kevin Daudt; +Cc: git
On Monday 18 September 2017 12:52 AM, Kevin Daudt wrote:
> Why is this empty line unwanted? This kind of whitespace can help
> separate logical sections, just like paragraphs would.
>
You're right. I seem to have sent a fix precariously because I haven't
such separation
before (forgetting the fact that git has contributors whose way of
writing test vary diversly).
Should better stop back and think the next time rather than spamming the
list. Sorry, for this.
---
Kaartic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-18 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-17 10:19 [PATCH] t2018: remove unwanted empty line Kaartic Sivaraam
2017-09-17 19:22 ` Kevin Daudt
2017-09-18 13:37 ` Kaartic Sivaraam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).