From: Derrick Stolee <stolee@gmail.com>
To: Nipunn Koorapati via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Nipunn Koorapati <nipunn1313@gmail.com>,
Nipunn Koorapati <nipunn@dropbox.com>
Subject: Re: [PATCH] perf/fsmonitor: use test_must_be_empty helper
Date: Mon, 30 Nov 2020 09:15:13 -0500 [thread overview]
Message-ID: <e82aa6f3-af88-246e-6cf8-5d2320133a59@gmail.com> (raw)
In-Reply-To: <pull.799.git.1606342297403.gitgitgadget@gmail.com>
On 11/25/2020 5:11 PM, Nipunn Koorapati via GitGitGadget wrote:
> From: Nipunn Koorapati <nipunn@dropbox.com>
>
> Simplify test and make error messages more clear here.
> Per feedback from Junio in
> 33226af42b (t/perf/fsmonitor: improve error message if typoing hook
> name, 2020-10-26)
Thanks, Nipunn. This patch looks good to me.
-Stolee
prev parent reply other threads:[~2020-11-30 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 22:11 [PATCH] perf/fsmonitor: use test_must_be_empty helper Nipunn Koorapati via GitGitGadget
2020-11-30 14:15 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e82aa6f3-af88-246e-6cf8-5d2320133a59@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=nipunn1313@gmail.com \
--cc=nipunn@dropbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).