From: Philippe Blain <levraiphilippeblain@gmail.com>
To: 滕龙 <dyroneteng@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: Help for the git patch with "---"
Date: Thu, 25 Feb 2021 08:22:42 -0500 [thread overview]
Message-ID: <e87e2ad1-e133-54d3-3f3d-8602ac242f64@gmail.com> (raw)
In-Reply-To: <25082af3-e8fd-e9d6-e980-43871c5b4840@gmail.com>
Le 2021-02-25 à 08:14, Philippe Blain a écrit :
> Hi Dyrone,
>
> [CC-ing the list]
>
> Le 2021-02-25 à 04:36, 滕龙 a écrit :
--snip--
>> I decide to remove it from the PR.
>>
>> So, did I deal the right way this time?
>
> Well, if you are sending a subsequent version of your patch series,
> this space is usually used to summarize in words what
> has changed since the last version of the patch series.
> For example, for your v4 you could have written:
>
> Changes since v3:
> - Improved <that> following comment from <insert reviewer name>
> - Reworded the commit message
> - etc.
>
> This is a explained in the MyFirstContribution tutorial [1]. I would
> encourage you to do that if your series needs a v5 (I haven't read it yet).
> It's also a way to make sure that you modified your patch to account
> for all feedback you got in earlier iterations.
>
Another thing: GitGitGadget adds a "CC:" footer in the PR description with
the email of every person that responds to your patch series on the mailing
list. This is then used to CC these persons when sending further iterations of
the series. So you should *not* remove these "CC:" footer when you update the PR
description to summarize you changes for each new version.
prev parent reply other threads:[~2021-02-25 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADMgQST4wSH+bt5auGuO6KYoQzyrkhnY2RY4Q1jGLVczGrMG+Q@mail.gmail.com>
[not found] ` <CADMgQSR8cOJs_XGuArqRoRxes6RxxgitMvDFYhpYVGxg6A2VZQ@mail.gmail.com>
2021-02-25 13:14 ` Help for the git patch with "---" Philippe Blain
2021-02-25 13:22 ` Philippe Blain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e87e2ad1-e133-54d3-3f3d-8602ac242f64@gmail.com \
--to=levraiphilippeblain@gmail.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).