From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: [PATCH] do not use locale specific strftime when preparing 2822 date Date: Fri, 07 Jul 2006 21:53:11 +0200 Organization: At home Message-ID: References: <7vlkr7bvc1.fsf@assigned-by-dhcp.cox.net> <1152298675925-git-send-email-jnareb@gmail.com> <7vveq9w736.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-From: git-owner@vger.kernel.org Fri Jul 07 21:53:43 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FywOI-0005pP-GC for gcvg-git@gmane.org; Fri, 07 Jul 2006 21:53:31 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932224AbWGGTx0 (ORCPT ); Fri, 7 Jul 2006 15:53:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932249AbWGGTx0 (ORCPT ); Fri, 7 Jul 2006 15:53:26 -0400 Received: from main.gmane.org ([80.91.229.2]:2499 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S932224AbWGGTxZ (ORCPT ); Fri, 7 Jul 2006 15:53:25 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FywNz-0005nq-Qn for git@vger.kernel.org; Fri, 07 Jul 2006 21:53:11 +0200 Received: from host-81-190-22-25.torun.mm.pl ([81.190.22.25]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 07 Jul 2006 21:53:11 +0200 Received: from jnareb by host-81-190-22-25.torun.mm.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 07 Jul 2006 21:53:11 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: git@vger.kernel.org X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: host-81-190-22-25.torun.mm.pl Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano wrote: > Jakub Narebski writes: > >> It looks like it is _almost_ correct. It should be >> Date: Fri, 07 Jul 2006 20:57:55 +0200 >> instead of >> Date: Fri, 7 Jul 2006 20:57:55 +0200 >> >> It is "day = ([FWS] 1*2DIGIT) / obs-day" in RFC2822. > > I think you are reading ABNF wrong. [...] > > See the definition of "hour" and friends a few lines below what > you quoted. It is defined as "2DIGIT / obs-hour" and that is > why we say "01:23:45" not "1:23:45" But it is "day = [...] 2DIGIT [...]"! Besides, that what other mailers do (I checked the post I replied via git-send-email to, i.e. your post). Although I don't think that it can cause any problems, like using locale date with non US-ASCII characters did... -- Jakub Narebski Warsaw, Poland ShadeHawk on #git