Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	 Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH] ci: work around Debian 12's HTTP/2 authentication failures
Date: Thu, 24 Sep 2026 20:59:24 +0200 (CEST)	[thread overview]
Message-ID: <e94a9d4f-567e-83a0-e12a-908082365e77@gmx.de> (raw)
In-Reply-To: <20260923192514.GA43344@coredump.intra.peff.net>

Hi Jeff,

On Wed, 23 Sep 2026, Jeff King wrote:

> On Wed, Sep 23, 2026 at 10:17:05AM -0700, Junio C Hamano wrote:
> 
> > Jeff King <peff@peff.net> writes:
> > 
> > > +# Curl 7.88.1 can fail to retry authentication after an early HTTP/2
> > > +# response. This was fixed in curl 8.3.0; see
> > > +# https://github.com/curl/curl/pull/11756. The first affected version is
> > > +# unknown, so conservatively assume that versions from 7.88.1 up to (but
> > > +# not including) 8.3.0 are broken.
> > 
> > Just nitpicking the wording, but if the first affected version is
> > truly unknown, assuming that versions from 7.88.1 up is *not* a
> > conservative thing to do at all, is it?
> > 
> > If 7.88.1 is from an irrelevantly ancient past, I would say that we
> > should just skip anything older than 8.3.0, but 7.88.1 is from early
> > 2023 and we cannot do such a simplification.
> 
> It depends on what bad outcome we are being conservative against. If the
> bad outcome is skipping the test on a version for which we could
> reliably use it, then it is conservative to only select known-bad
> versions. If the bad outcome is somebody running the test and seeing a
> flaky fail, then yes, the more conservative thing would be extending to
> skip older unknown versions (potentially up to "forever").
> 
> I think you could argue either way (and I am OK with either, or even
> just matching 7.88.1).

I had GPT-6 dig deeper into the issue, since you're right: This should not
be a CI/Debian-only gate, at the same time I didn't know what was the
first version with the bug, so I suspected the version range to be subtly
inaccurate. Turns out that the bug appeared first in cURL v7.88.0. So I
adjusted your version range in preparation for the next patch iteration.

Thank you!
Johannes

  reply	other threads:[~2026-09-24 18:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 23:06 [PATCH] ci: work around Debian 12's HTTP/2 authentication failures Johannes Schindelin via GitGitGadget
2026-09-23 16:16 ` Junio C Hamano
2026-09-23 16:47 ` Jeff King
2026-09-23 16:53   ` Jeff King
2026-09-23 16:59     ` Jeff King
2026-09-23 17:17       ` Junio C Hamano
2026-09-23 19:25         ` Jeff King
2026-09-24 18:59           ` Johannes Schindelin [this message]
2026-09-24 19:42             ` Junio C Hamano
2026-09-24 23:22             ` Jeff King
2026-09-24 20:53 ` [PATCH v2] " Johannes Schindelin via GitGitGadget
2026-10-06  3:43   ` [PATCH] t5551: fix quoting in curl version bug prereq Jeff King
2026-10-06  3:52     ` [PATCH 2/1] test-lib: allow lazy prerequisite snippets as here-docs Jeff King
2026-10-06  9:16     ` [PATCH] t5551: fix quoting in curl version bug prereq Johannes Schindelin
2026-10-06 12:25     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e94a9d4f-567e-83a0-e12a-908082365e77@gmx.de \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox