From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: use out-of-line GIT logo.
Date: Mon, 31 Jul 2006 07:21:39 +0200 [thread overview]
Message-ID: <eak40m$68u$1@sea.gmane.org> (raw)
In-Reply-To: 20060731035904.53458.qmail@web31813.mail.mud.yahoo.com
Luben Tuikov wrote:
> --- Martin Waitz <tali@admingilde.org> wrote:
>
>> Use the normal web server instead of the CGI to provide the git logo,
>> just like the gitweb.css.
>
> NACK. I'd really rather keep the logo (which is essential) in the
> file itself. This would mean one less file to worry about.
I'm not sure. On the one hand this introduces yet another file which we have
to worry about, on the other it probably help performance. Any hard
numbers?
The difference with gitweb.css is that you edit gitweb.css, and that
inclused CSS can be cached; we could probably do the same trick like with
logo (i.e. embed it in gitweb.css, but still use
<link rel="stylesheet" type="text/css" href="$my_uri?a=gitweb.css"/>
and not
<style type="text/css">
...
</style>
Besides, mixed language files are hard to syntax highlight correctly...
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-07-31 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-30 22:38 [PATCH] gitweb: use out-of-line GIT logo Martin Waitz
2006-07-31 3:59 ` Luben Tuikov
2006-07-31 5:21 ` Jakub Narebski [this message]
2006-07-31 7:02 ` Martin Waitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eak40m$68u$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).