From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: [PATCH 2] gitweb: Use list for of open for running git commands, thorougly. Date: Mon, 31 Jul 2006 14:10:02 +0200 Organization: At home Message-ID: References: <200607292239.11034.jnareb@gmail.com> <200607292251.21072.jnareb@gmail.com> <7virle6o5z.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-From: git-owner@vger.kernel.org Mon Jul 31 14:10:31 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G7WbC-00064o-B0 for gcvg-git@gmane.org; Mon, 31 Jul 2006 14:10:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750911AbWGaMKI (ORCPT ); Mon, 31 Jul 2006 08:10:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750962AbWGaMKI (ORCPT ); Mon, 31 Jul 2006 08:10:08 -0400 Received: from main.gmane.org ([80.91.229.2]:31907 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S1750911AbWGaMKH (ORCPT ); Mon, 31 Jul 2006 08:10:07 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1G7Waz-0005z4-7Q for git@vger.kernel.org; Mon, 31 Jul 2006 14:10:05 +0200 Received: from 193.0.122.19 ([193.0.122.19]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 31 Jul 2006 14:10:05 +0200 Received: from jnareb by 193.0.122.19 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 31 Jul 2006 14:10:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: git@vger.kernel.org X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 193.0.122.19 Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Jakub Narebski wrote: > Junio C Hamano wrote: > >> This, together with PATCH 6, seems to break "history" link. >> Visit a repository (summary page), click on "tree" on the second >> line, and click on "history" (on any blob or tree). > > Strange... returning this part of git_history to previous version, i.e. > > open my $fd, "-|", > "$GIT rev-list --full-history $hash_base -- \'$file_name\'"; > > still gives no history. Curious. Will examine that... Curiouser and curiouser. It seems that somehow --full-history option (which was never documented by the way) got lost somewhere. ~/git> git merge-base --all next HEAD 688a75071490101dbc660e3304aafb7a13e28807 ~/git> git log --full-history HEAD -- gitweb/test/file+plus+sign fatal: unrecognized argument: --full-history (same with 'git rev-list --full-history HEAD -- gitweb/test/file+plus+sign', but it shows help instead of simply croaking like git-log). -- Jakub Narebski Warsaw, Poland ShadeHawk on #git