From: "Zakirov Salikh" <salikh@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix "git add -u" data corruption.
Date: Thu, 16 Aug 2007 09:15:44 +0900 [thread overview]
Message-ID: <eb5812d90708151715k5125d4aq3008d7be54fa66b6@mail.gmail.com> (raw)
In-Reply-To: <7v1we4pknl.fsf_-_@gitster.siamese.dyndns.org>
Junio wrote:
> This applies to 'maint' to fix a rather serious data corruption
> issue. When "git add -u" affects a subdirectory in such a way
> that the only changes to its contents are path removals, the
> next tree object written out of that index was bogus, as the
> remove codepath forgot to invalidate the cache-tree entry.
Fixes the issue, thanks.
To make this more fair to git, especially to a notorious statement
"git never lost any data in its existence", this commit corruption,
while annoying, does not lose any data from working directory,
and was easy to fix and work around once I've figured out what's happened.
next prev parent reply other threads:[~2007-08-16 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 14:16 git-commit goes awry after git-add -u Salikh Zakirov
2007-08-15 14:21 ` Salikh Zakirov
2007-08-15 20:49 ` Junio C Hamano
2007-08-15 21:12 ` [PATCH] Fix "git add -u" data corruption Junio C Hamano
2007-08-16 0:15 ` Zakirov Salikh [this message]
2007-08-15 23:43 ` git-commit goes awry after git-add -u Salikh Zakirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5812d90708151715k5125d4aq3008d7be54fa66b6@mail.gmail.com \
--to=salikh@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).