From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: [PATCH/RFC] gitweb: Great subroutines renaming Date: Tue, 08 Aug 2006 22:24:52 +0200 Organization: At home Message-ID: References: <200608071626.52655.jnareb@gmail.com> <7v3bc82v7l.fsf@assigned-by-dhcp.cox.net> <7v4pwo1a0r.fsf@assigned-by-dhcp.cox.net> <7vejvsyum8.fsf@assigned-by-dhcp.cox.net> <7voduvugl9.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-From: git-owner@vger.kernel.org Tue Aug 08 22:25:26 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GAY8b-0000Nd-ET for gcvg-git@gmane.org; Tue, 08 Aug 2006 22:25:17 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030193AbWHHUZJ (ORCPT ); Tue, 8 Aug 2006 16:25:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932237AbWHHUZJ (ORCPT ); Tue, 8 Aug 2006 16:25:09 -0400 Received: from main.gmane.org ([80.91.229.2]:5034 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S932227AbWHHUZI (ORCPT ); Tue, 8 Aug 2006 16:25:08 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GAY8C-0000J9-QE for git@vger.kernel.org; Tue, 08 Aug 2006 22:24:53 +0200 Received: from host-81-190-31-92.torun.mm.pl ([81.190.31.92]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Aug 2006 22:24:52 +0200 Received: from jnareb by host-81-190-31-92.torun.mm.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Aug 2006 22:24:52 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: git@vger.kernel.org X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: host-81-190-31-92.torun.mm.pl Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano wrote: > Jakub Narebski writes: > >> Wouldn't it be better to (re)use notation of rpm's --query-format, >> i.e. use %{name}, or %30{name}, or %-30{name} for single scalar values, >> use :typetag output formats,... > > I did not do them because these enhancements are not needed to > unblock you from optimizing git_get_* calls in gitweb. These > enhancement can come later as long as the initial syntax is > simple, clean and extensible enough, which I think it is. Yes, that's true. I'm wondering if %(fieldname) of %{fieldname} would be better. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git