From: Phillip Wood <phillip.wood123@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] revert: initialize const value
Date: Mon, 4 Aug 2025 14:51:35 +0100 [thread overview]
Message-ID: <ebcc5e06-6d0f-43f0-951a-226558702a9e@gmail.com> (raw)
In-Reply-To: <aJC3OiJoqJRnR_My@pks.im>
On 04/08/2025 14:35, Patrick Steinhardt wrote:
> On Mon, Aug 04, 2025 at 09:01:41AM -0400, Jeff King wrote:
>>
>> Hmm, I guess one other option I did not consider: we could just drop the
>> "const". The pointers to it are "const char *", but it is fine for them
>> to point to a non-const variable. Maybe that is less mysterious.
>
> Initializing the value feels like a pragmatic choice to me. There is no
> downside, and anyone who might be puzzled by the comment is likely to
> git-blame(1) to your commit anyway. So I think the current version is
> good enough.
Yes the current version looks reasonable to me
Thanks
Phillip
next prev parent reply other threads:[~2025-08-04 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 13:00 [PATCH] revert: initialize const value Jeff King
2025-08-04 13:01 ` Jeff King
2025-08-04 13:35 ` Patrick Steinhardt
2025-08-04 13:51 ` Phillip Wood [this message]
2025-08-04 14:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebcc5e06-6d0f-43f0-951a-226558702a9e@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).