From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: use action dispatcher for non-project actions, too.
Date: Thu, 17 Aug 2006 22:00:50 +0200 [thread overview]
Message-ID: <ec2hrj$a37$1@sea.gmane.org> (raw)
In-Reply-To: 20060817194913.GD11477@admingilde.org
Martin Waitz wrote:
> hoi :)
>
> On Thu, Aug 17, 2006 at 11:41:43AM +0200, Jakub Narebski wrote:
>> > Project list and OPML generation are now hooked into the list as
>> > "/summary" and "/opml".
>>
>> It would be better to use "/list" or "/projects", although empty or
>> undef or "/" action would work as well.
>>
>> Having both "/summary" (for projects list) and "summary" (for project
>> summary) is bad, bad idea.
>
> well, it was a little trick so that only one default action "summary"
> is needed. I have no strong feelings about it so any other name is
> good for me, too.
if (defined $project) { # with the patch that undef $project when empty
$action ||= "summary";
} else {
$action ||= "/projects_list"; # or simply "projects_list", or "/"
}
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-08-17 20:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 22:28 [PATCH] gitweb: continue consolidation of URL generation Martin Waitz
2006-08-16 22:28 ` [PATCH] gitweb: use common parameter parsing and generation for "o", too Martin Waitz
2006-08-16 22:28 ` [PATCH] gitweb: support for "fp" parameter Martin Waitz
2006-08-16 22:28 ` [PATCH] gitweb: support for / as home_link Martin Waitz
2006-08-16 22:28 ` [PATCH] gitweb: fix project list if PATH_INFO=="/" Martin Waitz
2006-08-16 22:28 ` [PATCH] gitweb: use action dispatcher for non-project actions, too Martin Waitz
2006-08-17 2:06 ` Junio C Hamano
2006-08-17 15:00 ` Carl Worth
2006-08-18 13:16 ` Petr Baudis
2006-08-18 14:03 ` Carl Worth
2006-08-18 14:22 ` Jakub Narebski
2006-08-18 15:40 ` Petr Baudis
2006-08-17 19:43 ` Martin Waitz
2006-08-17 9:41 ` Jakub Narebski
2006-08-17 19:49 ` Martin Waitz
2006-08-17 20:00 ` Jakub Narebski [this message]
2006-08-17 9:35 ` [PATCH] gitweb: use common parameter parsing and generation for "o", too Jakub Narebski
2006-08-17 19:13 ` Martin Waitz
2006-08-17 19:34 ` Jakub Narebski
2006-08-18 20:20 ` Martin Waitz
2006-08-19 10:55 ` Jakub Narebski
2006-08-19 18:33 ` Martin Waitz
2006-08-19 21:44 ` Jakub Narebski
2006-08-17 1:59 ` [PATCH] gitweb: continue consolidation of URL generation Junio C Hamano
2006-08-17 19:32 ` Martin Waitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ec2hrj$a37$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).