* [PATCH] gitweb: bugfix: commitdiff regression
@ 2006-08-17 20:52 Luben Tuikov
2006-08-18 4:09 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Luben Tuikov @ 2006-08-17 20:52 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
Fix regression in git_commitdiff() introduced
by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Attachment #2: 2038685703-px.patch --]
[-- Type: application/octet-stream, Size: 690 bytes --]
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index bb77b55..b97342f 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2414,7 +2414,7 @@ sub git_commitdiff {
$cgi->a({-href => href(action=>"blob", hash=>$from_id, hash_base=>$hash_parent, file_name=>$file)}, $from_id) .
" -> " .
file_type($to_mode) . ":" .
- $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id) .
+ $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id);
print "</div>\n";
git_diff_print($from_id, "a/$file", $to_id, "b/$file");
}
--
1.4.2.g75c01
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] gitweb: bugfix: commitdiff regression
@ 2006-08-17 22:00 Luben Tuikov
2006-08-17 22:11 ` Jakub Narebski
0 siblings, 1 reply; 4+ messages in thread
From: Luben Tuikov @ 2006-08-17 22:00 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
Fix regression in git_commitdiff() introduced
by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Attachment #2: pat387950892 --]
[-- Type: application/octet-stream, Size: 690 bytes --]
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index bb77b55..b97342f 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2414,7 +2414,7 @@ sub git_commitdiff {
$cgi->a({-href => href(action=>"blob", hash=>$from_id, hash_base=>$hash_parent, file_name=>$file)}, $from_id) .
" -> " .
file_type($to_mode) . ":" .
- $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id) .
+ $cgi->a({-href => href(action=>"blob", hash=>$to_id, hash_base=>$hash, file_name=>$file)}, $to_id);
print "</div>\n";
git_diff_print($from_id, "a/$file", $to_id, "b/$file");
}
--
1.4.2.g75c01
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gitweb: bugfix: commitdiff regression
2006-08-17 22:00 [PATCH] gitweb: bugfix: commitdiff regression Luben Tuikov
@ 2006-08-17 22:11 ` Jakub Narebski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Narebski @ 2006-08-17 22:11 UTC (permalink / raw)
To: git
Luben Tuikov wrote:
> Fix regression in git_commitdiff() introduced
> by commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Could you please attach patches inline, and if it is not possible due to
whitespace munging, at least attach them as text/plain with 8bit encoding,
not base64 encoding?
TIA
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gitweb: bugfix: commitdiff regression
2006-08-17 20:52 Luben Tuikov
@ 2006-08-18 4:09 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2006-08-18 4:09 UTC (permalink / raw)
To: Luben Tuikov; +Cc: git
Well spotted; thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-18 4:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-17 22:00 [PATCH] gitweb: bugfix: commitdiff regression Luben Tuikov
2006-08-17 22:11 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2006-08-17 20:52 Luben Tuikov
2006-08-18 4:09 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).