From: Ben Keene <seraphire@gmail.com>
To: Yang Zhao <yang.zhao@skyboxlabs.com>
Cc: Denton Liu <liu.denton@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 00/13] git-p4: python3 compatibility
Date: Mon, 9 Dec 2019 13:54:53 -0500 [thread overview]
Message-ID: <ec301179-f9dc-4148-8634-2abc9263af5f@gmail.com> (raw)
In-Reply-To: <afa761cf-9c0e-cdcc-9c32-be88c5507042@gmail.com>
On 12/9/2019 10:03 AM, Ben Keene wrote:
>
> On 12/7/2019 2:59 PM, Yang Zhao wrote:
>> On Sat, Dec 7, 2019 at 8:21 AM Ben Keene <seraphire@gmail.com> wrote:
>>> On 12/7/2019 2:29 AM, Yang Zhao wrote:
>>>> Ideally, I would prefer we land something minimal and working in
>>>> mainline soon,
>>>> then further collaborate on changes that clean up code and enable
>>>> more features.
>>>>
>>>> My end-game is to have P4 Streams working in git-p4, and maybe
>>>> LFS-like support
>>>> that uses p4 as the backend. It would be great to not be the only one
>>>> spending effort
>>>> in that direction.
>>> I have similar goals. I would love to get the smallest set of
>>> non-breaking
>>> changes in that allows the program to basically work with Python 3.5+.
>>>
>>> My rush has been because I need to use git-p4 for work and have been
>>> working
>>> on the project at the office. Once I reach a point where I am able to
>>> generally work (when t9800 is complete) I'll really not be free to
>>> spend
>>> too
>>> much work time on the project, but I am eager to see this through!
>> I'm in a similar situation, but we use p4 Streams and so I actually
>> need further
>> development before being able to make a full switch. I am given more
>> liberty
>> in terms of how much work time I can dedicate to this, though.
>>
>> Given the situation, can you give my patch set a try in your work
>> environment?
>> It is currently passing everything except t9824-git-p4-git-lfs.
>
> I downloaded your code and it looks like it works for Python 2.7. I'm
> seeing errors with the following tests:
>
> * 9816.5
>
> Traceback (most recent call last):
> File "/home/bkeene/git/git-p4", line 4227, in <module>
> main()
> File "/home/bkeene/git/git-p4", line 4221, in main
> if not cmd.run(args):
> File "/home/bkeene/git/git-p4", line 2381, in run
> ok = self.applyCommit(commit)
> File "/home/bkeene/git/git-p4", line 2106, in applyCommit
> p4_write_pipe(['submit', '-i'], submitTemplate)
> File "/home/bkeene/git/git-p4", line 207, in p4_write_pipe
> return write_pipe(real_cmd, stdin)
> File "/home/bkeene/git/git-p4", line 201, in write_pipe
> die('Command failed: %s' % str(c))
> File "/home/bkeene/git/git-p4", line 158, in die
> raise Exception(msg)
> Exception: Command failed: ['p4', '-r', '3', 'submit', '-i']
>
> * 9816.6
>
> Traceback (most recent call last):
> File "/home/bkeene/git/git-p4", line 4227, in <module>
> main()
> File "/home/bkeene/git/git-p4", line 4221, in main
> if not cmd.run(args):
> File "/home/bkeene/git/git-p4", line 2381, in run
> ok = self.applyCommit(commit)
> File "/home/bkeene/git/git-p4", line 2106, in applyCommit
> p4_write_pipe(['submit', '-i'], submitTemplate)
> File "/home/bkeene/git/git-p4", line 207, in p4_write_pipe
> return write_pipe(real_cmd, stdin)
> File "/home/bkeene/git/git-p4", line 201, in write_pipe
> die('Command failed: %s' % str(c))
> File "/home/bkeene/git/git-p4", line 158, in die
> raise Exception(msg)
> Exception: Command failed: ['p4', '-r', '3', 'submit', '-i']
>
> * 9816.7
>
> Traceback (most recent call last):
> File "/home/bkeene/git/git-p4", line 4227, in <module>
> main()
> File "/home/bkeene/git/git-p4", line 4221, in main
> if not cmd.run(args):
> File "/home/bkeene/git/git-p4", line 2381, in run
> ok = self.applyCommit(commit)
> File "/home/bkeene/git/git-p4", line 2106, in applyCommit
> p4_write_pipe(['submit', '-i'], submitTemplate)
> File "/home/bkeene/git/git-p4", line 207, in p4_write_pipe
> return write_pipe(real_cmd, stdin)
> File "/home/bkeene/git/git-p4", line 201, in write_pipe
> die('Command failed: %s' % str(c))
> File "/home/bkeene/git/git-p4", line 158, in die
> raise Exception(msg)
> Exception: Command failed: ['p4', '-r', '3', 'submit', '-i']
>
> * 9816.9
>
> Traceback (most recent call last):
> File "/home/bkeene/git/git-p4", line 4227, in <module>
> main()
> File "/home/bkeene/git/git-p4", line 4221, in main
> if not cmd.run(args):
> File "/home/bkeene/git/git-p4", line 2381, in run
> ok = self.applyCommit(commit)
> File "/home/bkeene/git/git-p4", line 2106, in applyCommit
> p4_write_pipe(['submit', '-i'], submitTemplate)
> File "/home/bkeene/git/git-p4", line 207, in p4_write_pipe
> return write_pipe(real_cmd, stdin)
> File "/home/bkeene/git/git-p4", line 201, in write_pipe
> die('Command failed: %s' % str(c))
> File "/home/bkeene/git/git-p4", line 158, in die
> raise Exception(msg)
> Exception: Command failed: ['p4', '-r', '3', 'submit', '-i']
>
> * 9810.16
>
> Traceback (most recent call last):
> File "/home/bkeene/git/git-p4", line 4227, in <module>
> main()
> File "/home/bkeene/git/git-p4", line 4221, in main
> if not cmd.run(args):
> File "/home/bkeene/git/git-p4", line 2436, in run
> rebase.rebase()
> File "/home/bkeene/git/git-p4", line 3913, in rebase
> system("git rebase %s" % upstream)
> File "/home/bkeene/git/git-p4", line 305, in system
> raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command 'git rebase
> remotes/p4/master' returned non-zero exit status 1
>
> The last test was a breaking test that stopped the test make.
>
>
>> If you're OK with it, I would prefer that we work from my version as
>> a base and
>> add some of your quality-of-life enhancements on top. I can do the
>> merges myself
>> if you are pressed for time.
>>
>> Thanks,
>> Yang
>
> I am not a Python developer and my code is further behind than yours, so
> it makes complete sense to use yours as the base.
So, I just attempted to run a base case on windows: git p4 clone //depot
and I'm getting an error:
Depot paths must start with "//": /depot
next prev parent reply other threads:[~2019-12-09 18:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 0:33 [PATCH 00/13] git-p4: python3 compatibility Yang Zhao
2019-12-07 0:33 ` [PATCH 01/13] ci: also run linux-gcc pipeline with python-3.7 environment Yang Zhao
2019-12-10 10:30 ` SZEDER Gábor
2019-12-10 19:11 ` Yang Zhao
2019-12-12 14:13 ` SZEDER Gábor
2019-12-12 17:04 ` Yang Zhao
2019-12-12 17:15 ` SZEDER Gábor
2019-12-12 19:02 ` Yang Zhao
2019-12-07 0:33 ` [PATCH 02/13] git-p4: make python-2.7 the oldest supported version Yang Zhao
2019-12-07 0:33 ` [PATCH 03/13] git-p4: simplify python version detection Yang Zhao
2019-12-07 0:33 ` [PATCH 04/13] git-p4: decode response from p4 to str for python3 Yang Zhao
2019-12-07 0:33 ` [PATCH 05/13] git-p4: properly encode/decode communication with git for python 3 Yang Zhao
2019-12-07 0:33 ` [PATCH 06/13] git-p4: convert path to unicode before processing them Yang Zhao
2019-12-07 0:33 ` [PATCH 06/13] git-p4: open .gitp4-usercache.txt in text mode Yang Zhao
2019-12-07 0:33 ` [PATCH 07/13] git-p4: convert path to unicode before processing them Yang Zhao
2019-12-07 0:33 ` [PATCH 07/13] git-p4: open .gitp4-usercache.txt in text mode Yang Zhao
2019-12-07 0:33 ` [PATCH 08/13] git-p4: use marshal format version 2 when sending to p4 Yang Zhao
2019-12-07 0:33 ` [PATCH 09/13] git-p4: fix freezing while waiting for fast-import progress Yang Zhao
2019-12-07 0:33 ` [PATCH 10/13] git-p4: use functools.reduce instead of reduce Yang Zhao
2019-12-07 0:33 ` [PATCH 11/13] git-p4: use dict.items() iteration for python3 compatibility Yang Zhao
2019-12-07 0:33 ` [PATCH 12/13] git-p4: simplify regex pattern generation for parsing diff-tree Yang Zhao
2019-12-07 0:33 ` [PATCH 13/13] git-p4: use python3's input() everywhere Yang Zhao
2019-12-07 1:09 ` [PATCH 00/13] git-p4: python3 compatibility Denton Liu
2019-12-07 7:29 ` Yang Zhao
2019-12-07 16:21 ` Ben Keene
2019-12-07 19:59 ` Yang Zhao
2019-12-09 15:03 ` Ben Keene
2019-12-09 18:54 ` Ben Keene [this message]
2019-12-09 19:48 ` Johannes Schindelin
2019-12-10 14:20 ` Ben Keene
2019-12-09 20:21 ` Yang Zhao
2019-12-13 17:10 ` Ben Keene
2019-12-07 7:34 ` Yang Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec301179-f9dc-4148-8634-2abc9263af5f@gmail.com \
--to=seraphire@gmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=yang.zhao@skyboxlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).