git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Neulinger <nneul@neulinger.org>
To: git@vger.kernel.org
Subject: Recent changes for the unsafe directory handling - TINY improvement requested in error output
Date: Tue, 19 Apr 2022 06:26:52 -0500	[thread overview]
Message-ID: <ec588ff7-b300-bc3a-b51c-67d190b27e9b@neulinger.org> (raw)


While I understand the need for the recent changes (even if I'd prefer they be limited to turning off any 
filter/script/custom alias/etc. support) - there is one piece of the new behavior that could be improved for usability:

If you do a 'git status' in the directory - you get the "helpful" response:

   root@server:/local/APPNAME/bin# git status
   fatal: unsafe repository ('/local/APPNAME' is owned by someone else)
   To add an exception for this directory, call:

   git config --global --add safe.directory /local/APPNAME

However, if you do a 'git diff' - such as what you might naturally do right before attempting a 'git commit' - you do 
NOT get any useful response:

   root@SERVER:/local/APPNAME/bin# git diff
   warning: Not a git repository. Use --no-index to compare two paths outside a working tree
   usage: git diff --no-index [<options>] <path> <path>
   ...snip-long-diff-help...

Please consider a small improvement to have the git diff help output (if displayed due to the repo exclusion warning) - 
ALSO display the 'git config' suggestion at the end of the output, instead of me having to remember - oh, go issue 
status to get the command hint to go set the exclusion. Would also be useful to have the git diff output do the same 
'unsafe repository' message about ownership.



In case it matters for why I'm hitting this - server with various different application accounts. All maintained by a 
trusted list of users, but separated into different users for permissions isolation between the apps/repos/etc. Often 
edit/commit/etc. as other root or as other users (when facl's are being used). Running 1:2.25.1-1ubuntu3.3 on ubuntu 
20.04 in case this is already addressed in upstream and just not included in ubuntu repackaging.


-- Nathan

------------------------------------------------------------
Nathan Neulinger                       nneul@neulinger.org
Neulinger Consulting                   (573) 612-1412

             reply	other threads:[~2022-04-19 11:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 11:26 Nathan Neulinger [this message]
2022-04-20  6:16 ` Recent changes for the unsafe directory handling - TINY improvement requested in error output Bagas Sanjaya
2022-04-20 13:29   ` Nathan Neulinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec588ff7-b300-bc3a-b51c-67d190b27e9b@neulinger.org \
    --to=nneul@neulinger.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).