From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Support for snapshot
Date: Sat, 19 Aug 2006 13:09:34 +0200 [thread overview]
Message-ID: <ec6rha$aal$3@sea.gmane.org> (raw)
In-Reply-To: 7virkp3snv.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> +sub feature_snapshot {
> + my ($ctype, $suffix, $command) = @_;
> + my ($val) = git_get_project_config('snapshot');
> + if ($val eq 'gzip') { return ('gzip', 'gz'); }
> + elsif ($val eq 'bzip2') { return ('bzip2', 'bz2'); }
> + elsif ($val eq 'none') { return (); }
> +
> + return ($ctype, $suffix, $command);
> +}
Should it be ('x-gzip', 'gzip', 'gz') and ('x-bzip2', 'bzip2', 'bz2'),
i.e. with $ctype first?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-08-19 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 15:29 gitweb: Support for snapshot Aneesh Kumar K.V
2006-08-18 5:06 ` [PATCH] " Aneesh Kumar K.V
2006-08-18 19:51 ` Luben Tuikov
2006-08-18 20:05 ` Timo Hirvonen
[not found] ` <7v64gp7prk.fsf@assigned-by-dhcp.cox.net>
2006-08-19 8:10 ` Aneesh Kumar
2006-08-19 10:51 ` Junio C Hamano
2006-08-19 11:09 ` Jakub Narebski [this message]
2006-08-19 11:13 ` Jakub Narebski
2006-08-19 11:58 ` Aneesh Kumar K.V
2006-08-19 13:56 ` Aneesh Kumar K.V
2006-08-19 14:22 ` Jakub Narebski
2006-08-19 16:17 ` Aneesh Kumar K.V
2006-08-19 16:26 ` Aneesh Kumar K.V
2006-08-19 21:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ec6rha$aal$3@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).