From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 1/1] t3422: mark two test cases as requiring support for `--preserve-merges`
Date: Thu, 25 Jul 2019 02:16:33 -0700 (PDT) [thread overview]
Message-ID: <ed41e8d7abc93603063e9a99f628548608413d34.1564046191.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.296.git.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
We started marking all of those test cases that require `git rebase -p`
to work in the recent past, to allow for skipping them (because the
`--preserve-merges` backend is already deprecated and will be removed in
one of the next major versions, so it is a bit pointless to test its
functionality all the time).
This patch marks two previously forgotten test cases with the `REBASE_P`
prerequisite, to allow skipping them via setting the environment
variable `GIT_TEST_SKIP_REBASE_P`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
t/t3422-rebase-incompatible-options.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3422-rebase-incompatible-options.sh b/t/t3422-rebase-incompatible-options.sh
index bb78a6ec86..eb5cb67b06 100755
--- a/t/t3422-rebase-incompatible-options.sh
+++ b/t/t3422-rebase-incompatible-options.sh
@@ -65,12 +65,12 @@ test_rebase_am_only --ignore-whitespace
test_rebase_am_only --committer-date-is-author-date
test_rebase_am_only -C4
-test_expect_success '--preserve-merges incompatible with --signoff' '
+test_expect_success REBASE_P '--preserve-merges incompatible with --signoff' '
git checkout B^0 &&
test_must_fail git rebase --preserve-merges --signoff A
'
-test_expect_success '--preserve-merges incompatible with --rebase-merges' '
+test_expect_success REBASE_P '--preserve-merges incompatible with --rebase-merges' '
git checkout B^0 &&
test_must_fail git rebase --preserve-merges --rebase-merges A
'
--
gitgitgadget
next prev parent reply other threads:[~2019-07-25 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 9:16 [PATCH 0/1] Add the REBASE_P prerequisite to two more test cases Johannes Schindelin via GitGitGadget
2019-07-25 9:16 ` Johannes Schindelin via GitGitGadget [this message]
2019-07-25 16:23 ` [PATCH 1/1] t3422: mark two test cases as requiring support for `--preserve-merges` Junio C Hamano
2019-07-25 16:44 ` Junio C Hamano
2019-07-25 18:37 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed41e8d7abc93603063e9a99f628548608413d34.1564046191.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).