From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH/RFC 0/4] gitweb: ViewVC-like "tree_blame" view
Date: Thu, 31 Aug 2006 11:22:34 +0200 [thread overview]
Message-ID: <ed69or$285$2@sea.gmane.org> (raw)
In-Reply-To: ed5cke$n4m$1@sea.gmane.org
Jakub Narebski wrote:
> Josef Weidendorfer wrote:
>
>> On Thursday 31 August 2006 02:18, Jakub Narebski wrote:
>>> Ooops, I forgot to explain this. Strike-through, which actually should
>>> be using different color like red for example means that the file has
>>> 1-commit long history, i.e. it just appeared in given commit.
>>
>> Seems useful. Perhaps better green. And red for...
>> (As you talk about "just appeared") What's about deleted files, similar
>> to attic in CVS? It could be quite useful to provide an alternate
>> tree-blame mode including deleted files; where the given commit
>> would specify the deletion.
>
> Deletion, or renaming.
>
> Actually the currently used implementation (2-items max length history for
> each file) doesn't allow for that. The other two implementations (you can
> choose other 2 implementations by changing 'rev-list' in "my $version =
> shift || 'rev-list'" to 'diff-tree' or 'ls-tree') can do this. I think it
> would be perhaps easiest with git-ls-tree, if git-ls-tree would acquire
> --stdin option, similar to git-diff-tree...
Actually, unless you list only "accidental" deleted files, i.e. the ones
encountered during "blaming" all the files in given directory, you would
need to go all the way back to the root to be sure that all deleted or
renamed files are listed.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-08-31 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 22:43 [PATCH/RFC 0/4] gitweb: ViewVC-like "tree_blame" view Jakub Narebski
2006-08-30 23:08 ` Jakub Narebski
2006-08-31 0:00 ` Junio C Hamano
2006-08-31 0:18 ` Jakub Narebski
2006-08-31 0:47 ` Josef Weidendorfer
2006-08-31 1:05 ` Jakub Narebski
2006-08-31 9:22 ` Jakub Narebski [this message]
2006-08-31 8:20 ` Thomas Glanzmann
2006-08-31 9:20 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ed69or$285$2@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).