From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: [PATCH 0/4] gitweb: Some improvements Date: Tue, 05 Sep 2006 01:53:57 +0200 Organization: At home Message-ID: References: <200609041810.09838.jnareb@gmail.com> <7v8xkzkyie.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-From: git-owner@vger.kernel.org Tue Sep 05 01:54:26 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GKOGg-0001d4-8v for gcvg-git@gmane.org; Tue, 05 Sep 2006 01:54:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965063AbWIDXyQ (ORCPT ); Mon, 4 Sep 2006 19:54:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965064AbWIDXyQ (ORCPT ); Mon, 4 Sep 2006 19:54:16 -0400 Received: from main.gmane.org ([80.91.229.2]:52193 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S965063AbWIDXyP (ORCPT ); Mon, 4 Sep 2006 19:54:15 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GKOGS-0001bI-Cz for git@vger.kernel.org; Tue, 05 Sep 2006 01:54:04 +0200 Received: from host-81-190-21-28.torun.mm.pl ([81.190.21.28]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 05 Sep 2006 01:54:04 +0200 Received: from jnareb by host-81-190-21-28.torun.mm.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 05 Sep 2006 01:54:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: git@vger.kernel.org X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: host-81-190-21-28.torun.mm.pl Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano wrote: > Jakub Narebski writes: > >> This is small series of patches, applicable both to 'master' and 'next', >> which adds simple improvements, or in the case of last patch >> fix bug/typo. >> >> First two patches were sent earlier, I don't know if they were dropped >> or forgotten. > > I think you were just expecting too quick turnaround ;-). > > If I recall correctly it used to be that we could not use png > for favicon but it seems that things have improved. > > It is a while since I tried gitweb on my machine the last time > but was it always this slow I wonder... We probably would need > a good benchmark and automated test before going too much > further. The problem is that before commit 5d043a3d856bd40d8b34b8836a561e438d23573b gitweb: fill in gitweb configuration by Makefile by Martin Waitz one had to modify gitweb script to change the configuration from default. But benchmarking is good. Simple time to run script from command line, with environment variables GATEWAY_INTERFACE="CGI/1.1", HTTP_ACCEPT="*/*", REQUEST_METHOD="GET" and of course QUERY_STRING set, and perhaps using ApacheBench. >>From my experience with gitweb, the longest it take to show summary and tags views (for a large number of tags, which grows linearly with history), and to show history (and of course blame). -- Jakub Narebski Warsaw, Poland ShadeHawk on #git