Re: [PATCH] git-fetch should not strip off ".git" extension

["Leo Razoumov" <slonik.az@gmail.com>]

On 10/20/08, Junio C Hamano <gitster@pobox.com> wrote:
> Andreas Ericsson <ae@op5.se> writes:
>
>  >>...
>
> >>
>  >>  builtin-fetch--tool.c |    2 --
>  >>  builtin-fetch.c       |    2 --
>  >>  2 files changed, 0 insertions(+), 4 deletions(-)
>  >>
>  >> diff --git a/builtin-fetch--tool.c b/builtin-fetch--tool.c
>  >> index 7460ab7..5d0b95f 100644
>  >> --- a/builtin-fetch--tool.c
>  >> +++ b/builtin-fetch--tool.c
>  >> @@ -160,8 +160,6 @@ static int append_fetch_head(FILE *fp,
>  >>      for (i = remote_len - 1; remote[i] == '/' && 0 <= i; i--)
>  >>              ;
>  >>      remote_len = i + 1;
>  >> -    if (4 < i && !strncmp(".git", remote + i - 3, 4))
>  >> -            remote_len = i - 3;
>  >>
>  >>      note_len = 0;
>  >>      if (*what) {
>  >> diff --git a/builtin-fetch.c b/builtin-fetch.c
>  >> index ee93d3a..28123a5 100644
>  >> --- a/builtin-fetch.c
>  >> +++ b/builtin-fetch.c
>  >> @@ -348,8 +348,6 @@ static int store_updated_refs(const char *url,
>  >> const char *remote_name,
>  >>              for (i = url_len - 1; url[i] == '/' && 0 <= i; i--)
>  >>                      ;
>  >>              url_len = i + 1;
>  >> -            if (4 < i && !strncmp(".git", url + i - 3, 4))
>  >> -                    url_len = i - 3;
>  >>
>  >
>  > Will this still play nicely with
>  >
>  >   git clone foo.git
>  >
>  > ?
>
>
> I think it would.
>
>  As far as I can tell, the only thing the patch changes is to disable the
>  long established "repository name clean-up" feature in the autogenerated
>  merge messages (iow, input to "fmt-merge-msg").

Even though the old behavior is "long established", it introduces
unnecessary ambiguity. If I have two repos

(1) Foo      #private repo where I do my daily work
(2) Foo.git #exported public repo

the current behavior makes git messages confuse the repos.

--Leo--