From: "David Symonds" <dsymonds@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Blake Ramsdell" <blaker@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set
Date: Fri, 2 Nov 2007 22:23:51 +1100 [thread overview]
Message-ID: <ee77f5c20711020423t6ce58818gcc5220b6427ded1@mail.gmail.com> (raw)
In-Reply-To: <7vbqad3pjw.fsf@gitster.siamese.dyndns.org>
On 11/2/07, Junio C Hamano <gitster@pobox.com> wrote:
> "David Symonds" <dsymonds@gmail.com> writes:
>
> > Further, that comparison is going to fail as soon as the next revision
> > of Darwin (9.0.1, etc.) is released.
>
> Can we do something intelligent with $(shell iconv --version)
> there instead, I wonder, then?
It would probably be most appropriate for the autoconf script. Now
that I look at configure.ac, there's already a test for iconv in
there; is it not used?
Dave.
next prev parent reply other threads:[~2007-11-02 11:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 2:38 [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Blake Ramsdell
2007-11-02 2:38 ` [PATCH] Fixed a gcc 4.0.1 complaint about an uninitialized variable Blake Ramsdell
2007-11-02 5:37 ` Junio C Hamano
2007-11-02 9:03 ` [PATCH] Mac OS X 10.5 does not require the OLD_ICONV flag set Junio C Hamano
2007-11-02 9:20 ` Blake Ramsdell
2007-11-02 9:30 ` Mike Hommey
2007-11-02 9:39 ` Benoit SIGOURE
2007-11-02 9:45 ` Mike Hommey
2007-11-02 10:19 ` David Symonds
2007-11-02 10:33 ` Junio C Hamano
2007-11-02 11:23 ` David Symonds [this message]
2007-11-02 20:03 ` Blake Ramsdell
2007-11-03 0:00 ` [PATCH] Removed OLD_ICONV in favor of checking _LIBICONV_VERSION directly Blake Ramsdell
2007-11-03 0:07 ` Junio C Hamano
2007-11-03 0:21 ` Blake Ramsdell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee77f5c20711020423t6ce58818gcc5220b6427ded1@mail.gmail.com \
--to=dsymonds@gmail.com \
--cc=blaker@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).