git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David Symonds" <dsymonds@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: "Brian Gernhardt" <benji@silverinsanity.com>,
	"Jon Smirl" <jonsmirl@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>,
	gitster@pobox.com
Subject: Re: [PATCH 2/2] git status: show relative paths when run in a subdirectory
Date: Thu, 8 Nov 2007 11:53:48 +1100	[thread overview]
Message-ID: <ee77f5c20711071653x6a1fe8f8peb8ac2714941d2bb@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711080011170.4362@racer.site>

On Nov 8, 2007 11:12 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
>         This looks a bit ugly because quote_crlf() is now also called
>         on the untracked files, which are not NUL terminated.
>
>         Maybe someone has an idea how to do this more elegantly.
>
>  builtin-runstatus.c |    1 +
>  wt-status.c         |   50 ++++++++++++++++++++++++++++++++++++++++++--------
>  wt-status.h         |    1 +
>  3 files changed, 44 insertions(+), 8 deletions(-)

Tested, and looks good.

Now that I play with it, though, it seems that a few other bits of git
need updating to handle relative paths okay:

$ cd gitweb/test
$ rm ../../wt-status.h
    [oops, what a silly thing to do -- better checkout the latest
revision of it]
$ git status
# On branch next
# Changed but not updated:
#   (use "git add/rm <file>..." to update what will be committed)
#
#       deleted:    ../../wt-status.h
no changes added to commit (use "git add" and/or "git commit -a")
$ git checkout HEAD ../../wt-status.h
fatal: git-ls-files: cannot generate relative filenames containing '..'
    [grr....]
$ cd ../..
$ git checkout HEAD .
    [that works]



Dave.

  reply	other threads:[~2007-11-08  0:54 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 22:15 Inconsistencies with git log Jon Smirl
2007-11-07 22:42 ` Johannes Schindelin
2007-11-07 22:45   ` Jon Smirl
2007-11-07 22:58     ` Johannes Schindelin
2007-11-07 23:03       ` Jon Smirl
2007-11-07 23:11         ` Johannes Schindelin
2007-11-07 23:16           ` Jon Smirl
2007-11-07 23:29           ` Jon Smirl
2007-11-08  0:04             ` Johannes Schindelin
2007-11-08  0:09               ` Jon Smirl
2007-11-08  0:16                 ` Andreas Ericsson
2007-11-08  0:35                 ` Johannes Schindelin
2007-11-09 15:54                 ` Linus Torvalds
2007-11-09 17:20                   ` Jon Smirl
2007-11-09 17:38                     ` Linus Torvalds
2007-11-09 17:53                       ` Linus Torvalds
2007-11-09 18:04                         ` Jon Smirl
2007-11-09 18:14                           ` Linus Torvalds
2007-11-09 18:22                         ` Peter Baumann
2007-11-09 18:35                           ` Junio C Hamano
2007-11-09 18:37                             ` Jakub Narebski
2007-11-09 18:39                             ` Peter Baumann
2007-11-09 18:36                           ` Linus Torvalds
2007-11-09 17:41                     ` Jakub Narebski
2007-11-08  9:24             ` Wincent Colaiuta
2007-11-08 18:28             ` Daniel Barkalow
2007-11-07 23:19         ` Brian Gernhardt
2007-11-07 23:31           ` David Symonds
2007-11-08  0:09             ` Johannes Schindelin
2007-11-08  0:14               ` David Symonds
2007-11-08  0:52                 ` Brian Gernhardt
2007-11-08  0:10             ` [PATCH 1/2] Makefile: wt-status.h is also a lib header Johannes Schindelin
2007-11-08  0:11             ` Inconsistencies with git log Andreas Ericsson
2007-11-08  8:29               ` Peter Baumann
2007-11-08 13:16               ` David Symonds
2007-11-08 13:40                 ` Andreas Ericsson
2007-11-08 21:21                 ` Alex Riesen
2007-11-08 21:23                   ` Alex Riesen
2007-11-08  0:12             ` [PATCH 2/2] git status: show relative paths when run in a subdirectory Johannes Schindelin
2007-11-08  0:53               ` David Symonds [this message]
2007-11-08  1:00                 ` Johannes Schindelin
2007-11-08  8:26               ` Junio C Hamano
2007-11-09 15:30                 ` [PATCH REPLACEMENT for " Johannes Schindelin
2007-11-10 12:08                   ` Michel Marti
2007-11-10 14:10                     ` Johannes Schindelin
2007-11-08  9:19         ` Inconsistencies with git log Wincent Colaiuta
2007-11-10 22:51         ` Miles Bader
2007-11-07 23:00     ` David Symonds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee77f5c20711071653x6a1fe8f8peb8ac2714941d2bb@mail.gmail.com \
    --to=dsymonds@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonsmirl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).