git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David Symonds" <dsymonds@gmail.com>
To: "Junio C Hamano" <junio@pobox.com>
Cc: git@vger.kernel.org, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] git-checkout: Handle relative paths containing "..".
Date: Fri, 9 Nov 2007 00:10:20 +1100	[thread overview]
Message-ID: <ee77f5c20711080510i138729b9vb0b9ad485cb2db3@mail.gmail.com> (raw)
In-Reply-To: <7v4pfx3zs3.fsf@gitster.siamese.dyndns.org>

On Nov 8, 2007 7:30 PM, Junio C Hamano <junio@pobox.com> wrote:
>
> Have you tested this patch from the toplevel of any tree, where
> "git-rev-parse --show-cdup" would yield an empty string?

No, I didn't. Arguably, "git-rev-parse --show-cdup" should always
return a path to the top-level, which would make this kind of
construction much simpler. Is there anything that relies upon it
returning the empty string when you're in the top-level directory?

> I also wonder how this patch (with an obvious fix to address the
> above point) would interact with GIT_DIR and/or GIT_WORK_TREE in
> the environment.

No idea. I'm still learning my way around the git codebase, so I was
hoping for some review and feedback from more experienced Gits.


Dave.

  reply	other threads:[~2007-11-08 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08  2:33 [PATCH] git-checkout: Handle relative paths containing ".." David Symonds
2007-11-08  8:30 ` Junio C Hamano
2007-11-08 13:10   ` David Symonds [this message]
2007-11-08 14:25     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee77f5c20711080510i138729b9vb0b9ad485cb2db3@mail.gmail.com \
    --to=dsymonds@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).