git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David Symonds" <dsymonds@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Andreas Ericsson" <ae@op5.se>
Subject: Re: [PATCH] git-checkout: Test for relative path use.
Date: Fri, 9 Nov 2007 12:44:53 +1100	[thread overview]
Message-ID: <ee77f5c20711081744p5d7b46fo88a582b9f5dbdab8@mail.gmail.com> (raw)
In-Reply-To: <7vtznwxl59.fsf@gitster.siamese.dyndns.org>

On Nov 9, 2007 12:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
> David Symonds <dsymonds@gmail.com> writes:
>
> > Signed-off-by: David Symonds <dsymonds@gmail.com>
> > ---
> >       Test 5 in this series fails because of a bug in git-ls-files, where
> >               git-ls-files t/../
> >       (with or without --full-name) returns no files.
>
> Heh, you shouldn't do that ;-)
>
> Seriously, that's a long standing limitation in the code, not to
> deal with arbitrary combination of ups and downs, but I do not
> think there is any fundamental reason to disallow something
> like:
>
>         cd Documentation && git ls-files --full-name ../t
>
> Patches welcome.

So you're otherwise happy with my tests, despite one of them
triggering an (unrelated to git-checkout) bug? Or would you prefer I
remove that particular failure from the tests and resend?


Dave.

  reply	other threads:[~2007-11-09  1:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09  0:36 [PATCH] git-checkout: Support relative paths containing ".." David Symonds
2007-11-09  0:36 ` [PATCH] git-checkout: Test for relative path use David Symonds
2007-11-09  1:28   ` Junio C Hamano
2007-11-09  1:44     ` David Symonds [this message]
2007-11-09  1:54       ` Junio C Hamano
2007-11-09  1:57         ` David Symonds
2007-11-09 19:48     ` Robin Rosenberg
2007-11-09  7:13   ` Johannes Sixt
2007-11-09  7:24     ` David Symonds
2007-11-09  7:37       ` David Symonds
2007-11-09  8:04       ` Junio C Hamano
2007-11-09  8:14         ` David Symonds
2007-11-09  9:06           ` Junio C Hamano
2007-11-09  9:10             ` David Symonds
2007-11-09  9:12               ` David Symonds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee77f5c20711081744p5d7b46fo88a582b9f5dbdab8@mail.gmail.com \
    --to=dsymonds@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).