git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: ds/config-literal-value (was Re: What's cooking in git.git (Nov 2020, #06; Mon, 30))
Date: Wed, 2 Dec 2020 08:22:58 -0500	[thread overview]
Message-ID: <ee7a17a2-25a0-d8c9-f686-4ce3a22616e0@gmail.com> (raw)
In-Reply-To: <xmqqtut6qf7q.fsf@gitster.c.googlers.com>

On 12/1/2020 12:15 AM, Junio C Hamano wrote:
> * ds/config-literal-value (2020-11-25) 8 commits
>  - config doc: value-pattern is not necessarily a regexp
>  - config: implement --fixed-value with --get*
>  - config: plumb --fixed-value into config API
>  - config: add --fixed-value option, un-implemented
>  - t1300: add test for --replace-all with value-pattern
>  - t1300: test "set all" mode with value-pattern
>  - config: replace 'value_regex' with 'value_pattern'
>  - config: convert multi_replace to flags
>  (this branch is used by ds/maintenance-part-3.)
> 
>  Various subcommands of "git config" that takes value_regex
>  learn the "--literal-value" option to take the value_regex option
>  as a literal string.
> 
>  Expecting a (hopefully final) reroll.

Hi Junio,

Did this expectation of a reroll get updated since v3? My understanding
is that any remaining feedback is related to the angle brackets, which
are consistent with the surrounding documentation (and should be tackled
in a separate series). Do you mean that you want me to update the lines
I'm touching to use angle brackets?

Or, do you mean that I should re-roll to include the patch you sent [1]
for between patches 7 and 8?

[1] https://lore.kernel.org/git/xmqq7dq9ca94.fsf@gitster.c.googlers.com/

Thanks,
-Stolee

  parent reply	other threads:[~2020-12-02 13:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  5:15 What's cooking in git.git (Nov 2020, #06; Mon, 30) Junio C Hamano
2020-12-01  9:46 ` [PATCH] cook: add github.com/git-vcs/git as a URL Ævar Arnfjörð Bjarmason
2020-12-01  9:58   ` [PATCH] MaintNotes: use https:// instead of git:// when possible Ævar Arnfjörð Bjarmason
2020-12-01 11:54     ` Jeff King
2020-12-01 19:07       ` Junio C Hamano
2020-12-02  1:43         ` Jeff King
2020-12-01 11:47   ` [PATCH] cook: add github.com/git-vcs/git as a URL Jeff King
2020-12-01 19:10     ` Junio C Hamano
2020-12-02  1:44       ` Jeff King
2020-12-01 18:57   ` Junio C Hamano
2020-12-02  4:33 ` What's cooking in git.git (Nov 2020, #06; Mon, 30) Felipe Contreras
2020-12-02 13:22 ` Derrick Stolee [this message]
2020-12-02 22:14   ` ds/config-literal-value (was Re: What's cooking in git.git (Nov 2020, #06; Mon, 30)) Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee7a17a2-25a0-d8c9-f686-4ce3a22616e0@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).