From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Fix showing of path in tree view
Date: Thu, 21 Sep 2006 01:38:49 +0200 [thread overview]
Message-ID: <eesje4$qku$2@sea.gmane.org> (raw)
In-Reply-To: eesj84$qku$1@sea.gmane.org
Jakub Narebski wrote:
> Petr Baudis wrote:
>
>> This patch fixes two things - links to all path elements except the last
>> one were broken since gitweb does not like the trailing slash in them, and
>> the root tree was not reachable from the subdirectory view.
>>
>> To compensate for the one more slash in the front, the trailing slash is
>> not there anymore. ;-) I don't care if it stays there though.
>
> Originally '/' was used as separator between directories making the path.
> I'd rather use ' / ' to separate parts of pathname more, and not incorporate
> it in the link.
>
> Trailing (final) slash is present (and I think should be present) only
> for path in "tree" view. From the path alone you can see if it is "tree"
> or "blob" view.
About link to root tree: we could change the commit title to link to root
tree instead of linking to commit view.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-09-20 23:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 23:12 [PATCH] gitweb: Fix showing of path in tree view Petr Baudis
2006-09-20 23:32 ` Junio C Hamano
2006-09-20 23:40 ` Petr Baudis
2006-09-20 23:51 ` Junio C Hamano
2006-09-21 8:50 ` Jakub Narebski
2006-09-21 11:25 ` Petr Baudis
2006-09-20 23:35 ` Jakub Narebski
2006-09-20 23:38 ` Jakub Narebski [this message]
2006-09-20 23:43 ` Petr Baudis
2006-09-21 10:19 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eesje4$qku$2@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).