From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: Re: [PATCH] gitweb: Fix showing of path in tree view Date: Thu, 21 Sep 2006 12:19:29 +0200 Organization: At home Message-ID: References: <20060920231224.GN13132@pasky.or.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-From: git-owner@vger.kernel.org Thu Sep 21 12:21:02 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GQLfV-0001NJ-Fr for gcvg-git@gmane.org; Thu, 21 Sep 2006 12:20:36 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750699AbWIUKUU (ORCPT ); Thu, 21 Sep 2006 06:20:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750704AbWIUKUU (ORCPT ); Thu, 21 Sep 2006 06:20:20 -0400 Received: from main.gmane.org ([80.91.229.2]:13766 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S1750699AbWIUKUT (ORCPT ); Thu, 21 Sep 2006 06:20:19 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GQLep-00019l-Em for git@vger.kernel.org; Thu, 21 Sep 2006 12:19:51 +0200 Received: from host-81-190-26-109.torun.mm.pl ([81.190.26.109]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 21 Sep 2006 12:19:51 +0200 Received: from jnareb by host-81-190-26-109.torun.mm.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 21 Sep 2006 12:19:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: git@vger.kernel.org X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: host-81-190-26-109.torun.mm.pl Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Petr Baudis wrote: > This patch fixes two things - links to all path elements except the last > one were broken since gitweb does not like the trailing slash in them, and > the root tree was not reachable from the subdirectory view. Wouldn't it be better to fix git_get_hash_by_path to have it strip trailing slash? Gitweb don't like trailing slash in pathname (directory name) because while git ls-tree $base -- dirname shows dirname entry git ls-tree $base -- dirname/ shows directory _contents_. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git